Postinstallation Job "storage-version-migration-eventing" inmemorychannels

[VikSh404]

The post-installation job went down when we upgraded the version from 1.14 to 1.15.

To Reproduce:

• Install knative eventing1.14 (without a default Channel (messaging) layer)
• upgrade to 1.15 using the instructions: https://knative.dev/v1.15-docs/install/yaml-install/eventing/install-eventing-with-yaml/#verify-the-installation

kubectl create -f eventing-post-install.yaml
clusterrole.rbac.authorization.k8s.io/knative-eventing-post-install-job-role created
serviceaccount/knative-eventing-post-install-job created
clusterrolebinding.rbac.authorization.k8s.io/knative-eventing-post-install-job-role-binding created
job.batch/storage-version-migration-eventing-kfm2q created

We had an error in storage-version-migration-eventing job:

We needed to delete the CRD from the list of the args of the storage-version-migration-eventing:

          args:
            - "apiserversources.sources.knative.dev"
            - "brokers.eventing.knative.dev"
            - "channels.messaging.knative.dev"
            - "containersources.sources.knative.dev"
            - "eventtypes.eventing.knative.dev"
            - "inmemorychannels.messaging.knative.dev"    <------ deleted this CRD
            - "parallels.flows.knative.dev"
            - "pingsources.sources.knative.dev"
            - "sequences.flows.knative.dev"
            - "sinkbindings.sources.knative.dev"
            - "subscriptions.messaging.knative.dev"
            - "triggers.eventing.knative.dev"
            - "jobsinks.sinks.knative.dev"

It helped us to apply the post-install script. Is it expected behavior? It looks like the "inmemorychannels.messaging.knative.dev" should be optional.

[pierDipi]

I think there is an IGNORE_NOT_FOUND env variable [1] we could configure in the Job [2].

[1] https://github.com/knative/pkg/blob/efddeac3ec350b35316c3e1f9f0d79092a13eed1/apiextensions/storageversion/cmd/migrate/main.go#L37-L60
[2] https://github.com/knative/eventing/blob/main/config/post-install/storage-version-migrator.yaml

/good-first-issue

[knative-prow]

@pierDipi:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

I think there is an IGNORE_NOT_FOUND env variable [1] we could configure in the Job [2].

[1] https://github.com/knative/pkg/blob/efddeac3ec350b35316c3e1f9f0d79092a13eed1/apiextensions/storageversion/cmd/migrate/main.go#L37-L60
[2] https://github.com/knative/eventing/blob/main/config/post-install/storage-version-migrator.yaml

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.