Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] await send() never resolves if file is not found #145

Open
3 tasks
TheDirigible opened this issue Jul 10, 2022 · 2 comments
Open
3 tasks

[fix] await send() never resolves if file is not found #145

TheDirigible opened this issue Jul 10, 2022 · 2 comments
Labels

Comments

@TheDirigible
Copy link

Describe the bug

using this example code:
await send(ctx, ctx.path, { root: __dirname + '/public' });
If the file is not found, the promise never resolves. This is a memory leak.

Node.js version:

OS version:

Description:

Actual behavior

Expected behavior

Code to reproduce

Checklist

  • I have searched through GitHub issues for similar issues.
  • I have completely read through the README and documentation.
  • I have tested my code with the latest version of Node.js and this package and confirmed it is still not working.
@houd1ni
Copy link

houd1ni commented Feb 25, 2023

Hi! It rejects, isn't it ?

@etroynov
Copy link

etroynov commented Sep 9, 2023

@TheDirigible the problem is solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants