Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests to confirm the behavior when format and extensions are conflicted #66

Open
haoxins opened this issue Jan 10, 2017 · 1 comment

Comments

@haoxins
Copy link
Member

haoxins commented Jan 10, 2017

If we have the file structure below

/hello
/hello.html
/hello/index.html

with options

{
  index: 'index.html',
  extensions: ['.html']
}
@Necromos
Copy link
Contributor

@coderhaoxin
Hmmm after first look I found out that:

  1. GET /hello:
    /hello.html is served (which in my opinion is correct but I would like to hear yours)

  2. GET /hello.html:
    hello.html is served (expected) even if options is set to:

{ 
  index: 'index.html',
  extensions: ['.txt', '.html'] 
}
  1. GET /hello/:
    is serving index.html (expected)

If all is ok then I can push tests for these cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants