-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there any way to set cookie domain per request rather than per server launch? #188
Comments
@Kumagor0 .. I'm facing the same issue.. did you have any luck with resolving this? |
@Natouriano no, not yet. Fortunately that's not a pressing matter for me, but if it was, I'd just fork this repo, make the changes I proposed in the original post, publish it under a new name and use that package instead of koa-session. |
This seems to do the job https://github.com/Secbone/koa-session2 |
@olso Does it? Because looking at the docs,
looks like setting all options once and for all. |
What prevents you from wrapping it and forwarding ctx,next? This is per request @Kumagor0 My issue with |
Created a draft PR to support modifying the cookie domain on a per-request basis - #227 |
Right now I have the following code in my index.js:
The problem is, it sets domain once and for all and then passes that value to ctx.cookie.set() every time. What I need is customizable cookie domain based on request values like hostname or query etc. I can elaborate on the use case I need that for, if that's of any relevance. I don't see how can I do that currently, but I found a solution which basically creates new koa-session middleware on every request:
This would work, but unfortunately 2 out of 3 properties defined here have configurable set to false implicitly, so on the second request I get "TypeError: Cannot redefine property: sessionOptions" error.
So, I have 3 questions:
Is there any way to achieve what I need with koa-session right now that I've missed?
If previous answer is "no", is there any real reason sessionOptions and [CONTEXT_SESSION] are non-configurable?
If previous answer is "no", can it be changed to configurable? What needs to be done for that (do I need to submit PR or something)?
The text was updated successfully, but these errors were encountered: