Skip to content

Commit 16e3d60

Browse files
committed
tokenrenewer: do not buffer signals
Otherwise we lose control on when the signal should be handled. In particular, buffering disconnect signal causes disconnect signal for old renewLoop goroutine being handled by the new one.
1 parent bf214c2 commit 16e3d60

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tokenrenewer.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ func NewTokenRenewer(r *Client, k *Kite) (*TokenRenewer, error) {
3131
t := &TokenRenewer{
3232
client: r,
3333
localKite: k,
34-
signalRenewToken: make(chan struct{}, 1),
35-
disconnect: make(chan struct{}, 1),
34+
signalRenewToken: make(chan struct{}),
35+
disconnect: make(chan struct{}),
3636
}
3737
return t, t.parse(r.Auth.Key)
3838
}

0 commit comments

Comments
 (0)