Remove variables from src/DB.php or remove static.

[rjd22]

In src/DB.php it is using static classes. This is not really wrong since they are returning classes instances so they are still injectable.

What should be changed is that they become true factories by removing the parameters from the static function unless it has something to do with the factory.

A different solution would be removing the statics so that you can just inject the DB class directly into a class. That way it will act a some kind of facade.

Since PHP 5.4 statics are not really useful anymore for their "nice" syntax. You can now do something like this: $select = (new Database)->select($params);

[shadowhand]

Since PHP 5.4 statics are not really useful anymore for their "nice" syntax.

Doesn't work so well for query builders:

$query = (new Database_Query_Builder_Select); // vs
$query = DB::select();

[rjd22]

@shadowhand you I agree that DB::select() is a nicer syntax maybe we should do something like DB::query_builder()->select($prop) ?