Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UB sanitizer: most TwostageGaussSeidel_functor ctors do not set forward_sweep field #2418

Closed
cwpearson opened this issue Nov 6, 2024 · 1 comment
Assignees

Comments

@cwpearson
Copy link
Contributor

An example failure here: https://github.com/kokkos/kokkos-kernels/actions/runs/11695504241/job/32571033270

I'm not 100% sure this is actually the problem, but I think it is: this causes the implicitly-defined copy-ctor for this (called internally by Kokkos in e.g. parallel_for) to initialize this bool field from whatever happens to be in memory, which is usually not technically a valid boolean value (e.g. 157).

In Trilinos/packages/kokkos-kernels/sparse/impl/KokkosSparse_twostage_gauss_seidel_impl.hpp

@cwpearson
Copy link
Contributor Author

Fixed in #2420

@cwpearson cwpearson reopened this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants