Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang=en vs. lang=default #746

Open
karussell opened this issue Aug 22, 2023 · 2 comments
Open

lang=en vs. lang=default #746

karussell opened this issue Aug 22, 2023 · 2 comments

Comments

@karussell
Copy link
Collaborator

See the following requests:

https://photon.komoot.io/api/?q=primeke&lang=default&lat=59.863704493020094&lon=17.639317368224624

https://photon.komoot.io/api/?q=primeke&lang=en&lat=59.863704493020094&lon=17.639317368224624

Both OSM nodes have only a "name" tag and no "name:en", so that I wouldn't expect a difference.

@lonvia
Copy link
Collaborator

lonvia commented Feb 9, 2024

The two queries have already different result lists when used without the location bias. We currently structure the query such that the location bias more or less only results in reordering of the search results without location bias, so that the closer result is never really considered.

lang=default gives so much more of a boost to 'Primekens Kopf' in 'Permecke' (both somewhat similar to 'q=primeke' that the other possible matches are discarded.

This needs some deeper structural changes to the ES query to get fixed. Possibly an early result boost for location bias and bbox.

@dbapl
Copy link

dbapl commented Jul 19, 2024

Even with exact query, name is not found in lang=default results:
https://photon.komoot.io/api/?lang=default&q=ko%C5%82obrzeg%20arka%20medical%20spa

{
  "features": [
    {
      "geometry": {
        "coordinates": [
          -94.33896690580423,
          35.435261749999995
        ],
        "type": "Point"
      },
      "type": "Feature",
      "properties": {
        "osm_id": 449782625,
        "extent": [
          -94.3401048,
          35.4364568,
          -94.3381908,
          35.4342108
        ],
        "country": "United States",
        "city": "Van Buren",
        "countrycode": "US",
        "postcode": "72956",
        "county": "Crawford",
        "type": "house",
        "osm_type": "W",
        "osm_key": "amenity",
        "street": "Hospital Drive",
        "osm_value": "hospital",
        "name": "Sparks Medical Center – Van Buren",
        "state": "Arkansas"
      }
    },
    {
      "geometry": {
        "coordinates": [
          -94.1570476,
          36.1233038
        ],
        "type": "Point"
      },
      "type": "Feature",
      "properties": {
        "osm_id": 7986400171,
        "country": "United States",
        "city": "Fayetteville",
        "countrycode": "US",
        "postcode": "72741",
        "locality": "Uptown Fayetteville",
        "county": "Washington",
        "type": "house",
        "osm_type": "N",
        "osm_key": "shop",
        "street": "North Steele Boulevard",
        "osm_value": "beauty",
        "name": "Rejuvenated Medical Spa",
        "state": "Arkansas"
      }
    },
    {
      "geometry": {
        "coordinates": [
          35.1972653,
          31.7088576
        ],
        "type": "Point"
      },
      "type": "Feature",
      "properties": {
        "osm_id": 4833263921,
        "country": "Palestinian Territory",
        "city": "بيت لحم",
        "countrycode": "PS",
        "locality": "حارة الفرحية",
        "county": "منطقة أ",
        "type": "house",
        "osm_type": "N",
        "osm_key": "amenity",
        "street": "شارع القدس-الخليل",
        "osm_value": "clinic",
        "name": "المركز التخصصي الطبي",
        "state": "الضفة الغربية"
      }
    },
    {
      "geometry": {
        "coordinates": [
          69.22607087018868,
          41.2770398
        ],
        "type": "Point"
      },
      "type": "Feature",
      "properties": {
        "osm_id": 987644503,
        "extent": [
          69.2248161,
          41.2783131,
          69.2275279,
          41.2758929
        ],
        "country": "Oʻzbekiston",
        "city": "Ташкент",
        "countrycode": "UZ",
        "postcode": "100115",
        "locality": "Chilonzor 2 mavzesi",
        "type": "house",
        "osm_type": "W",
        "osm_key": "amenity",
        "street": "Arnasoy ko'chasi",
        "district": "Chilonzor Tumani",
        "osm_value": "hospital",
        "name": "Republican Specialized Scientific and Practical Medical Center of Hematology"
      }
    },
    {
      "geometry": {
        "coordinates": [
          -1.4507874,
          42.5454715
        ],
        "type": "Point"
      },
      "type": "Feature",
      "properties": {
        "osm_type": "N",
        "osm_id": 6611776154,
        "country": "España",
        "osm_key": "tourism",
        "city": "Eslava",
        "street": "Carretera Estella - Tafalla - Sangüesa / Lizarra - Tafalla - Zangoza errepidea",
        "countrycode": "ES",
        "osm_value": "information",
        "name": "Remodelación de la torre medieval, soportales, columnas, empalizada, foro",
        "county": "Zangozerria / Comarca de Sangüesa",
        "state": "Navarra - Nafarroa",
        "type": "house"
      }
    }
  ],
  "type": "FeatureCollection"
}

but matched in lang=en
https://photon.komoot.io/api/?lang=en&q=ko%C5%82obrzeg%20arka%20medical%20spa

{
  "features": [
    {
      "geometry": {
        "coordinates": [
          15.6084242,
          54.1890784
        ],
        "type": "Point"
      },
      "type": "Feature",
      "properties": {
        "osm_id": 1721650053,
        "country": "Poland",
        "city": "Kołobrzeg",
        "countrycode": "PL",
        "postcode": "78-100",
        "locality": "Luboszyce",
        "county": "Colberg County",
        "type": "house",
        "osm_type": "N",
        "osm_key": "tourism",
        "housenumber": "11",
        "street": "Antoniego Sułkowskiego",
        "district": "Ogrody",
        "osm_value": "hotel",
        "name": "Arka Medical Spa",
        "state": "West Pomeranian Voivodeship"
      }
    }
  ],
  "type": "FeatureCollection"
}```

gnomesysadmins pushed a commit to GNOME/gnome-maps that referenced this issue Aug 23, 2024
Explicitly set 'en' when using a language not specifically
supported by GraphHopper instead of relying on leaving out
the parameter, as this has some issues.
See: komoot/photon#746
gnomesysadmins pushed a commit to GNOME/gnome-maps that referenced this issue Aug 23, 2024
Explicitly set 'en' when using a language not specifically
supported by GraphHopper instead of relying on leaving out
the parameter, as this has some issues.
See: komoot/photon#746
gnomesysadmins pushed a commit to GNOME/gnome-maps that referenced this issue Aug 23, 2024
Explicitly set 'en' when using a language not specifically
supported by GraphHopper instead of relying on leaving out
the parameter, as this has some issues.
See: komoot/photon#746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants