New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Services and Routes are missing #31

Open

nevalla opened this issue Sep 7, 2018 · 6 comments

Contributor

nevalla commented Sep 7, 2018

Instead of Api object there are now Service and Route objects

Contributor

arthurmde commented Nov 11, 2019

Is there any ongoing effort to handle this issue?

If not, I can intent to help.

Contributor

mtmail commented Nov 11, 2019

I have a branch that added those and I use it with Kong 1.1 and 1.4. https://github.com/kontena/kong-client-ruby/compare/master...mtmail:kong1dot1?expand=1

Contributor

arthurmde commented Nov 12, 2019

Do you intend to create a PR?

Contributor Author

nevalla commented Nov 12, 2019

@mtmail very nice! PRs are always welcome.

Contributor

mtmail commented Nov 12, 2019

PR created now. Not even sure why I didn't do that back in April.

Contributor

arthurmde commented Dec 17, 2019

This has been fixed in #38

@nevalla is there anything missing in the PR to be approved and published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment