Skip to content

Setting supportsPagination to false doesn't work #1197

@eelcoberghuis

Description

@eelcoberghuis

Summary: setting the supportsPagination option for a provider to false doesn't work.

The default setting for supportsPagination = true as can be seen in metadata-defaults.js. To set the value to false the supportPagination can be included in the metadata that is returned together with the geojson. Below an example:

Image

However, when the metadata is used to populate the json in the FeatureServer the supportsPagination property is stripped. When the metadata isused in the function mixinOverrides the supportsPagination setting is removed from the options parameter containing the metadata.

Image

The function .pickBy in normalizeInput is responsible for removing the supportsPagination = false. As a result the function _setPagination will never receive a false value as input.

According to the documentation of .pickBy this function returns on _truthy _ properties from an object. This explains why supportsPagination is removed from the metadata.

Can this be fixed by changing the default for supportsPagination to false or to change the logic in normalizeInput to retain the value for supportPagination?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions