Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump request to koreader/master? #539

Open
Schizosaccaromyces opened this issue Jan 29, 2025 · 5 comments
Open

Bump request to koreader/master? #539

Schizosaccaromyces opened this issue Jan 29, 2025 · 5 comments

Comments

@Schizosaccaromyces
Copy link
Contributor

Hi,

I realized that I can't test the changes on #538 since this has not been bumped to master - sorry to be a nag but could this repo be bumped to koreader/master so it shows in the nightly for me to test?

Also, would this be a good example for trying to write a lights controller for this device? As none of the current drivers support it I may try my hand at it.
bad071d#diff-70eadf1b0a93dd261a4ec1e53148958e4fcfbe339363e707ad9b070d52d6d2b6

@hugleo
Copy link
Contributor

hugleo commented Jan 29, 2025

I'll add support for one more device in a few days if someone wants to do it before then do...
Yes, it's a good example. Just a note: the lightsMap variable is no longer needed since the device names are now unified to a single name for both the device and the lights.

@Schizosaccaromyces
Copy link
Contributor Author

Schizosaccaromyces commented Jan 30, 2025

Thank you for the bumping - Compatibility test still shows as unsupported and seems it did not add refresh rate or dithering support to my device so I'll try to prowl the test log and see if I can figure out why (This is with today's nightly which contained my changes).
For reference, what functions become enabled once the device is using the compatible eink driver? In case it's actually working but I haven't noticed.

@hugleo
Copy link
Contributor

hugleo commented Jan 30, 2025

It should show supported in the e-ink test. The nightly generated package may not yet be reflecting the latest changes or there may be something wrong with the device match.

@Frenzie
Copy link
Member

Frenzie commented Jan 30, 2025

The nightly is built with koreader/koreader@9911ef7 so provided that's the build we're talking about it would be the device match.

@Schizosaccaromyces
Copy link
Contributor Author

Schizosaccaromyces commented Jan 30, 2025

It is that nightly - will check if I did put something wrong in the device match fields.
EDIT: Yes, I did....It's "ro7802", not "r07802". Argh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants