Fixes

Author: alekseykret0v

wagtail_ab_testing/models.py

@@ -271,7 +271,7 @@ def log_conversion(self, version, *, time=None):
         AbTestHourlyLog._increment_stats(self, version, 0, 1, time=time)
 
     def check_for_winner(self):
-	return None
+	    return None
 
     def get_status_description(self):
         """
@@ -292,7 +292,7 @@ def get_status_description(self):
                 return status + " (" + _("Variant won") + ")"
 
             else:
-                return status + " (" + _("No clear winner") + ")"
+                return status
 
         else:
             return status

wagtail_ab_testing/templates/wagtail_ab_testing/results.html

@@ -41,9 +41,7 @@ <h2>{{ ab_test.name }}</h2>
             </svg>
             <div class="abtest-results">
                 <div class="abtest-results__version abtest-results__version--control">
-                    <div class="abtest-results__version-heading{% if control_is_winner or unclear_winner %} abtest-results__version-heading--winner{% endif %}">
-                        {% if control_is_winner %}{% icon "crown" %} {% trans "Winner!" %}{% elif unclear_winner %}{% trans "No clear winner" %}{% endif %}
-                    </div>
+                    <div class="abtest-results__version-heading"></div>
                     <div class="abtest-results__version-inner">
                         <h3>{% trans "Control" %} <a href="{% pageurl page %}" target="_blank">{% icon name="link-external" %}</a></h3>
 
@@ -75,9 +73,7 @@ <h3>{% trans "Control" %} <a href="{% pageurl page %}" target="_blank">{% icon n
                     </div>
                 </div>
                 <div class="abtest-results__version abtest-results__version--variant">
-                    <div class="abtest-results__version-heading{% if variant_is_winner or unclear_winner %} abtest-results__version-heading--winner{% endif %}">
-                        {% if variant_is_winner %}{% icon "crown" %} {% trans "Winner!" %}{% elif unclear_winner %}{% trans "No clear winner" %}{% endif %}
-                    </div>
+                    <div class="abtest-results__version-heading"></div>
                     <div class="abtest-results__version-inner">
                         <h3>{% trans "Variant" %} <a href="{% url 'wagtailadmin_pages:view_draft' page.id %}" target="_blank">{% icon name="link-external" %}</a></h3>
 

wagtail_ab_testing/views.py

@@ -268,31 +268,12 @@ def get_progress_and_results_common_context(request, page, ab_test):
             estimated_completion_date = timezone.now().date() + datetime.timedelta(days=estimated_days_remaining)
 
     # Generate time series data for the chart
-    time_series = []
-    control = 0
-    variant = 0
-    date = None
+    counters = {"control": 0, "variant": 0}
+    time_series_dict = {}
     for log in ab_test.hourly_logs.order_by('date', 'hour'):
-        # Accumulate the conversions
-        if log.version == AbTest.VERSION_CONTROL:
-            control += log.conversions
-        else:
-            variant += log.conversions
-
-        while date is None or date < log.date:
-            if date is None:
-                # First record
-                date = log.date
-            else:
-                # Move time forward to match log record
-                date += datetime.timedelta(days=1)
-
-            # Generate a log for this time
-            time_series.append({
-                'date': date,
-                'control': control,
-                'variant': variant,
-            })
+        counters[log.version] += log.conversions
+        time_series_dict[log.date] = {'date': log.date, **counters}
+    time_series = time_series_dict.values()
 
     return {
         'page': page,