-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove laravelcollective/html #684
Comments
Do you have examples? |
laravelcollective/html is now abandoned, and there's no guarantee that it will be updated to support Laravel 11, at the moment it is fixed to support up to Laravel 10 only (https://github.com/LaravelCollective/html/blob/6.x/composer.json#L22). It would be worth coming up with a plan for what to do here. |
I'm sure it won't be updated to support laravel 11. I would probably fork it, or publish it with a different name and then It's such a shame laravelcollective didn't just pass the baton. I've asked many times to take over, and other have too, but no dice =( |
Someone forked it already which is published at https://github.com/LaravelLux/html - though there's nothing to say that that fork will become the "official fork" or whether that fork will continue to be maintained, its too early to tell really. |
That won't work. Changing the namespace is too breaking. It should have changed nothing and used composer's |
@rudiedirkx that makes sense. For context, in our project we use both this package as well as laravelcollective/html directly in hundreds of places, so as this package also pulls in laravelcollective/html we'll probably do whatever you guys decide to do here to avoid having two almost identical but slightly different forks in the same project. So is that fork you describe something you are seriously planning to do in order to support Laravel 11+? If so, I will hold off making any changes in our project, until that fork is available, then I'll switch out laravelcollective/html for that fork in our project too when its available and this package has also swapped it out. |
I do that too in several projects. I've recently changed Works like a charm. Perfectly backward and forward comatible. As long as I maintain rdx/laravelcollective-html and other packages keep requiring |
@rudiedirkx so you're saying that we don't need to update this laravel-form-builder package's composer.json to require the fork, instead it is up to us in each project's composer.json to require the fork and also add a |
You don't have to do anything with The form builder package will keep requiring I've added the install steps in https://github.com/rudiedirkx/laravelcollective-html, maybe that's clear enough? |
Looks good to me, thanks @rudiedirkx! |
The is an converter available https://laravelshift.com/convert-laravelcollective-html-to-spatie-laravel-html |
Laravel have good view component to build form, it would be great if we can remove laravelcollective/html
The text was updated successfully, but these errors were encountered: