"use strict" is a Good Idea

codefrau · codefrau · commit af7a3157ba26 · 2014-12-10T13:02:45.000+01:00
diff --git a/jit.js b/jit.js
@@ -1,4 +1,5 @@
 module('users.bert.SqueakJS.jit').requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";    
 /*
  * Copyright (c) 2014 Bert Freudenberg
  *
diff --git a/plugins/ADPCMCodecPlugin.js b/plugins/ADPCMCodecPlugin.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.ADPCMCodecPlugin").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";    
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/plugins/B2DPlugin.js b/plugins/B2DPlugin.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.B2DPlugin").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";    
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/plugins/BitBltPlugin.js b/plugins/BitBltPlugin.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.BitBltPlugin").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/plugins/FFTPlugin.js b/plugins/FFTPlugin.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.FFTPlugin").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/plugins/FloatArrayPlugin.js b/plugins/FloatArrayPlugin.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.FloatArrayPlugin").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/plugins/GeniePlugin.js b/plugins/GeniePlugin.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.GeniePlugin").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/plugins/JPEGReaderPlugin.js b/plugins/JPEGReaderPlugin.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.JPEGReaderPlugin").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/plugins/KedamaPlugin.js b/plugins/KedamaPlugin.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.KedamaPlugin").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/plugins/KedamaPlugin2.js b/plugins/KedamaPlugin2.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.KedamaPlugin2").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/plugins/Klatt.js b/plugins/Klatt.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.Klatt").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/plugins/LargeIntegers.js b/plugins/LargeIntegers.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.LargeIntegers").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/plugins/Matrix2x3Plugin.js b/plugins/Matrix2x3Plugin.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.Matrix2x3Plugin").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/plugins/MiscPrimitivePlugin.js b/plugins/MiscPrimitivePlugin.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.MiscPrimitivePlugin").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/plugins/ScratchPlugin.js b/plugins/ScratchPlugin.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.ScratchPlugin").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/plugins/SoundGenerationPlugin.js b/plugins/SoundGenerationPlugin.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.SoundGenerationPlugin").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/plugins/StarSqueakPlugin.js b/plugins/StarSqueakPlugin.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.StarSqueakPlugin").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/plugins/ZipPlugin.js b/plugins/ZipPlugin.js
@@ -6,6 +6,7 @@
  */
 
 module("users.bert.SqueakJS.plugins.ZipPlugin").requires("users.bert.SqueakJS.vm").toRun(function() {
+"use strict";
 
 var VM_PROXY_MAJOR = 1;
 var VM_PROXY_MINOR = 11;
diff --git a/squeak.js b/squeak.js
@@ -20,13 +20,14 @@
  * THE SOFTWARE.
  */
 
+"use strict";    
 
 //////////////////////////////////////////////////////////////////////////////
 // these functions fake the Lively module and class system
 // just enough so the loading of vm.js succeeds
 //////////////////////////////////////////////////////////////////////////////
 
-module = function(dottedPath) {
+window.module = function(dottedPath) {
     if (dottedPath == "") return window;
     var path = dottedPath.split("."),
         name = path.pop(),
diff --git a/vm.js b/vm.js
@@ -1,4 +1,5 @@
 module('users.bert.SqueakJS.vm').requires().toRun(function() {
+"use strict";    
 /*
  * Copyright (c) 2013,2014 Bert Freudenberg
  *
@@ -559,19 +560,19 @@ Object.extend(Squeak,
         var path = this.splitFilePath(dirpath),
             localEntries = localStorage["squeak:" + path.fullname],
             template = includeTemplates && localStorage["squeak-template:" + path.fullname];
-        if (localEntries || template) {
-            var dir = {};
-            function addEntries(entries) {
-                for (var key in entries) {
-                    if (entries.hasOwnProperty(key)) {
-                        var entry = entries[key];
-                        dir[entry[0]] = entry;
-                    }
+        function addEntries(dir, entries) {
+            for (var key in entries) {
+                if (entries.hasOwnProperty(key)) {
+                    var entry = entries[key];
+                    dir[entry[0]] = entry;
                 }
             }
+        }
+        if (localEntries || template) {
             // local entries override templates
-            if (template) addEntries(JSON.parse(template).entries);
-            if (localEntries) addEntries(JSON.parse(localEntries));
+            var dir = {};
+            if (template) addEntries(dir, JSON.parse(template).entries);
+            if (localEntries) addEntries(dir, JSON.parse(localEntries));
             return dir;
         }
         if (path.fullname == "/") return {};
@@ -899,17 +900,17 @@ Object.subclass('Squeak.Image',
                 return false;   // don't do more
             }
         };
+        function mapSomeObjectsAsync() {
+            if (mapSomeObjects()) {
+                window.setTimeout(mapSomeObjectsAsync, 0);
+            } else {
+                if (thenDo) thenDo();
+            }
+        };
         if (!progressDo) {
             while (mapSomeObjects());   // do it synchronously
             if (thenDo) thenDo();
         } else {
-            function mapSomeObjectsAsync() {
-                if (mapSomeObjects()) {
-                    window.setTimeout(mapSomeObjectsAsync, 0);
-                } else {
-                    if (thenDo) thenDo();
-                }
-            };
             window.setTimeout(mapSomeObjectsAsync, 0);
         }
      },

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`module('users.bert.SqueakJS.jit').requires("users.bert.SqueakJS.vm").toRun(function() {`
	`2`	`+"use strict";`
`2`	`3`	`/*`
`3`	`4`	`* Copyright (c) 2014 Bert Freudenberg`
`4`	`5`	`*`