Skip to content

Commit bed92e4

Browse files
laymonagegasman
authored andcommitted
Use breadcrumbs for wagtail.locales views
1 parent 9fc53dc commit bed92e4

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

wagtail/locales/tests.py

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,10 @@ def test_simple(self):
2020
response = self.get()
2121
self.assertEqual(response.status_code, 200)
2222
self.assertTemplateUsed(response, "wagtailadmin/generic/index.html")
23-
self.assertBreadcrumbsNotRendered(response.content)
23+
self.assertBreadcrumbsItemsRendered(
24+
[{"url": "", "label": "Locales"}],
25+
response.content,
26+
)
2427

2528

2629
class TestLocaleCreateView(AdminTemplateTestUtils, WagtailTestUtils, TestCase):
@@ -43,7 +46,13 @@ def test_simple(self):
4346
response = self.get()
4447
self.assertEqual(response.status_code, 200)
4548
self.assertTemplateUsed(response, "wagtaillocales/create.html")
46-
self.assertBreadcrumbsNotRendered(response.content)
49+
self.assertBreadcrumbsItemsRendered(
50+
[
51+
{"label": "Locales", "url": "/admin/locales/"},
52+
{"label": "New: Locale", "url": ""},
53+
],
54+
response.content,
55+
)
4756

4857
self.assertEqual(
4958
response.context["form"].fields["language_code"].choices, [("fr", "French")]
@@ -116,7 +125,13 @@ def test_simple(self):
116125
response = self.get()
117126
self.assertEqual(response.status_code, 200)
118127
self.assertTemplateUsed(response, "wagtaillocales/edit.html")
119-
self.assertBreadcrumbsNotRendered(response.content)
128+
self.assertBreadcrumbsItemsRendered(
129+
[
130+
{"url": "/admin/locales/", "label": "Locales"},
131+
{"url": "", "label": str(self.english)},
132+
],
133+
response.content,
134+
)
120135

121136
self.assertEqual(
122137
response.context["form"].fields["language_code"].choices,

wagtail/locales/views.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ class LocaleViewSet(ModelViewSet):
9898
model = Locale
9999
permission_policy = locale_permission_policy
100100
add_to_reference_index = False
101-
_show_breadcrumbs = False
102101

103102
index_view_class = IndexView
104103
add_view_class = CreateView

0 commit comments

Comments
 (0)