Skip to content

fix(mikrotik): fix check_file_exists mikrotik output handling #3741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(mikrotik): fix check_file_exists mikrotik output handling #3741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions netmiko/mikrotik/mikrotik_ssh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,15 +200,23 @@ def check_file_exists(self, remote_cmd: str = "") -> bool:
if not remote_cmd:
remote_cmd = f'/file print detail where name="{self.file_system}/{self.dest_file}"'
remote_out = self.ssh_ctl_chan._send_command_timing_str(remote_cmd)
# Output will look like
# 0 name="flash/test9.txt" type=".txt file" size=19 creation-time=jun...
# fail case will be blank line (all whitespace)
# Possible outputs:
# - Normal entry containing 'size' and the filename
# 0 name="flash/test9.txt" type=".txt file" size=19 creation-time=...
# - Some firmware versions print flags then the entry
# Flags: S - shared
# 0 name="flash/test9.txt" type=".txt file" size=19 creation-time=...
# - Or only the flags (no matching file), or entirely blank on failure
# Flags: S - shared
# <no matching file line>
if (
"size" in remote_out
and f"{self.file_system}/{self.dest_file}" in remote_out
):
return True
elif not remote_out.strip():
elif not remote_out.strip() or (
"Flags:" in remote_out and "size" not in remote_out
):
return False
raise ValueError("Unexpected output from check_file_exists")
elif self.direction == "get":
Expand Down