Prevent Empty Cookie addition (#2008)

ggasbarri · web-flow · commit b5bcb7c1adb9 · 2020-08-10T15:19:09.000+03:00
diff --git a/ktor-client/ktor-client-core/common/src/io/ktor/client/features/cookies/HttpCookies.kt b/ktor-client/ktor-client-core/common/src/io/ktor/client/features/cookies/HttpCookies.kt
@@ -71,7 +71,9 @@ class HttpCookies(
                 val cookies = feature.get(context.url.clone().build())
 
                 with(context) {
-                    headers[HttpHeaders.Cookie] = renderClientCookies(cookies)
+                    if (cookies.isNotEmpty()) {
+                        headers[HttpHeaders.Cookie] = renderClientCookies(cookies)
+                    }
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,9 @@ class HttpCookies(`
`71`	`71`	`val cookies = feature.get(context.url.clone().build())`
`72`	`72`
`73`	`73`	`with(context) {`
`74`		`- headers[HttpHeaders.Cookie] = renderClientCookies(cookies)`
	`74`	`+ if (cookies.isNotEmpty()) {`
	`75`	`+ headers[HttpHeaders.Cookie] = renderClientCookies(cookies)`
	`76`	`+ }`
`75`	`77`	`}`
`76`	`78`	`}`
`77`	`79`