Skip to content

Commit 24836aa

Browse files
Merge pull request #142 from kubecost/mmd/fix-resource-sum-gpu
Fix request sum returning non-totaled GPU
2 parents 5383b73 + 1cbff28 commit 24836aa

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

pkg/cmd/predict.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,8 @@ func sumContainerResources(replicas int, spec v1.PodSpec) v1.ResourceList {
159159

160160
// Only include GPU data if we have any. Put under the generic "gpu"
161161
// name because we don't (currently) distinguish between providers.
162-
if !podGPU.IsZero() {
163-
result[resourceGPUKey] = *podGPU
162+
if !totalGPU.IsZero() {
163+
result[resourceGPUKey] = *totalGPU
164164
}
165165

166166
return result

test/multi.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@ spec:
7070
requests:
7171
cpu: "2"
7272
memory: "7Gi"
73+
limits:
74+
nvidia.com/gpu: 1
7375
---
7476
apiVersion: v1
7577
kind: Pod

0 commit comments

Comments
 (0)