Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After the modbus device connects to the mapper, the container of the mapper fails. #108

Closed
NicoleLeeuu opened this issue Jul 31, 2023 · 2 comments

Comments

@NicoleLeeuu
Copy link
Member

The Modbus Mapper is running normally. After the device is delivered, the container of the mapper fails.
微信图片_20230731171819
View the mapper log. The command output is "panic: runtime error: invalid memory address or nil pointer dereference".
微信图片_20230731170900
Locate the problem. It was found that the payload in the Run() function, located in the mappers/modbus-dmi/device/twindata.go file, did not add the "Expected" data section. This results in an error when accessing msg.Twin.Expected when executing the parse.ConvMsgTwinToGrpc(msg.Twin) function.
Is this a bug in the process of design and implementation? If so, please leave bugfix matters to me.

@QiQi-OvO
Copy link
Contributor

QiQi-OvO commented Aug 1, 2023

Yes, this is a bug that has been fixed by two PRs(#99, #105), but they haven't been merged into the code repository yet.

@cl2017
Copy link
Contributor

cl2017 commented Aug 18, 2023

Yes, this is a bug that has been fixed by two PRs(#99, #105), but they haven't been merged into the code repository yet.

Let's review these PRs again and merged it into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants