Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

[Feature Request] Provides a better common logger #60

Open
Jeffwan opened this issue Apr 5, 2020 · 3 comments
Open

[Feature Request] Provides a better common logger #60

Jeffwan opened this issue Apr 5, 2020 · 3 comments

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Apr 5, 2020

Currently, kubeflow/common provides a logger utils for operator to use. It uses github.com/sirupsen/logrus underneath.

https://github.com/kubeflow/common/blob/master/pkg/util/logger.go#L20

The problem I notice is new operators using kubebuilder have inbuilt logger for operator logics.
This makes the logs really messy.

Can we provide a interface layer like logr and provide method like SetLogger and different operator can use their own implementation?

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
feature 0.97

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@jlewi jlewi added kind/feature and removed feature labels Apr 6, 2020
@terrytangyuan
Copy link
Member

Agreed. Having a unified interface would make it easier for downstream apps to consume the logs.

@terrytangyuan
Copy link
Member

cc @ShuhanYan @carmark in case you are interested

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants