-
Notifications
You must be signed in to change notification settings - Fork 22
Open
Labels
kind/enhancementkind - new features or changeskind - new features or changespriority/needs-triagepriority - needs to be triagedpriority - needs to be triaged
Description
Checks
- I have searched the existing issues.
- My request is related to one of the components in the
kubeflow/dashboard
repository.
Motivation
This came up while we were working on the migration script #154 (comment)
Right now the kubeflow/manifests
repo holds NetworkPolicy
manifests for the components of this repo. With the renaming of the components that we did #118 (comment) we'll also need to ensure the updated labels are applied everywhere.
Currently, we are blocked from creating a migration script as the following is happening:
- The manifests repo apply the following NetworkPolicy, that is allowing traffic for a Pod with label
app: centraldashboard
- The new dashboard app has labels
app: dashboard
instead - The Istio IngressGateway that lives in the
istio-system
namespace needs to talk to the Dashboard - The
NetworkPolicy
now doesn't match, and we end up getting timeouts when trying to access the dashboard
Implementation
We'll need to move NetworkPolicy
objects from the kubeflow/manifests
repo to this repo's componetns.
This way we can centralise the manifests updates in the future, and ensure we don't have to apply and track changes across different repos.
We'll need to transfer the NetworkPolicies
for:
- Centraldashboard
- PodDefautls, note that this is not causing issues as the labels have stayed the same across the renamings
Are you willing & able to help?
- I am able to submit a PR!
- I can help test the feature!
Metadata
Metadata
Assignees
Labels
kind/enhancementkind - new features or changeskind - new features or changespriority/needs-triagepriority - needs to be triagedpriority - needs to be triaged