feat: Upgrade Go to 1.24 - notebook-controller component. #721

Signed-off-by: Abdallah Samara (EXT-Nokia) <[email protected]>

Author: Abdallah Samara (EXT-Nokia)

.github/workflows/nb_controller_integration_test.yaml

@@ -64,4 +64,4 @@ jobs:
           | sed "s|${CURRENT_IMAGE}:[a-zA-Z0-9_.-]*|${PR_IMAGE}|g" \
           | kubectl apply -f -
 
-        kubectl wait pods -n kubeflow -l app=notebook-controller --for=condition=Ready --timeout=300s
+        kubectl wait pods -n kubeflow -l app=notebook-controller --for=condition=Ready --timeout=300s

.github/workflows/nb_controller_multi_arch_test.yaml

@@ -34,4 +34,4 @@ jobs:
         cd components/notebook-controller
         ARCH=linux/amd64 make docker-build-multi-arch
         ARCH=linux/ppc64le make docker-build-multi-arch
-        ARCH=linux/arm64/v8 make docker-build-multi-arch
+        ARCH=linux/arm64/v8 make docker-build-multi-arch

.github/workflows/nb_controller_unit_test.yaml

@@ -1,12 +1,11 @@
 name: Run Notebook Controller unit tests
 on:
-  pull_request:
+  push:
     paths:
       - components/notebook-controller/**
       - releasing/version/VERSION
     branches:
-      - main
-      - notebooks-v1
+      - feat/721
       - v*-branch
 
 jobs:
@@ -19,7 +18,7 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: "1.17"
+        go-version: "1.24"
         check-latest: true
 
     - name: Run unit tests

.github/workflows/tb_controller_docker_publish.yaml

@@ -61,4 +61,4 @@ jobs:
       if: steps.filter.outputs.version == 'true'
       run: |
         export TAG=$(cat ../../releasing/version/VERSION)
-        make docker-build-push-multi-arch
+        make docker-build-push-multi-arch

components/notebook-controller/Dockerfile

@@ -4,7 +4,7 @@
 #
 # ${PATH_TO_KUBEFLOW/KUBEFLOW repo}/components
 #
-ARG GOLANG_VERSION=1.17
+ARG GOLANG_VERSION=1.24
 FROM golang:${GOLANG_VERSION} as builder
 
 WORKDIR /workspace
@@ -16,6 +16,14 @@ COPY notebook-controller /workspace/notebook-controller
 # and so that source changes don't invalidate our downloaded layer
 RUN cd /workspace/notebook-controller && go mod download
 
+# Force download and extract all HashiCorp modules so they exist under /go/pkg/mod
+RUN set -e; cd /workspace/notebook-controller; \
+  for m in $(go list -m all | awk '/^github.com\/hashicorp\// {print $1 "@" $2}'); do \
+    go mod download "$m"; \
+    pkg="${m%@*}"; \
+    go list "$pkg/..." >/dev/null 2>&1 || true; \
+  done
+
 WORKDIR /workspace/notebook-controller
 
 # Build

components/notebook-controller/Makefile

@@ -136,7 +136,7 @@ undeploy: ## Undeploy controller from the K8s cluster specified in ~/.kube/confi
 CONTROLLER_GEN = $(shell pwd)/bin/controller-gen
 .PHONY: controller-gen
 controller-gen: ## Download controller-gen locally if necessary.
-	$(call go-get-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen@v0.8.0)
+	$(call go-get-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen@v0.14.0)
 
 KUSTOMIZE = $(shell pwd)/bin/kustomize
 .PHONY: kustomize

components/notebook-controller/README.md

@@ -80,7 +80,7 @@ notebook-controller-deployment-564d76877-mqsm8   1/1     Running   0          16
 ```
 
 ### Build and Run the Controller locally
-In order to build the controller you will need to use Go 1.17 and up in order to have Go Modules support. You will also need to have a k8s cluster.
+In order to build the controller you will need to use Go 1.24 and up in order to have Go Modules support. You will also need to have a k8s cluster.
 
 1. Install the CRDs into the cluster:
 
@@ -135,7 +135,7 @@ make uninstall
 
 To develop on `notebook-controller`, your environment must have the following:
 
-- [go](https://golang.org/dl/) version v1.17+.
+- [go](https://golang.org/dl/) version v1.24+.
 - [docker](https://docs.docker.com/install/) version 20.10+.
 - [kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/) version 1.22.0+.
 - [kustomize](https://sigs.k8s.io/kustomize/docs/INSTALL.md) version 3.8.7+.

components/notebook-controller/go.mod

@@ -1,6 +1,6 @@
 module github.com/kubeflow/kubeflow/components/notebook-controller
 
-go 1.17
+go 1.24
 
 require (
 	github.com/go-logr/logr v1.2.0