feat: Upgrade Go to 1.24 - notebook-controller component. #721

Signed-off-by: Abdallah Samara (EXT-Nokia) <[email protected]>

Author: Abdallah Samara (EXT-Nokia)

.github/workflows/nb_controller_docker_publish.yaml

@@ -2,16 +2,15 @@ name: Build & Publish Notebook Controller Docker image
 on:
   push:
     branches:
-      - main
-      - v*-branch
+      - feat/721
       - notebooks-v1
     paths:
       - components/notebook-controller/**
       - components/common/**
       - releasing/version/VERSION
 
 env:
-  IMG: ghcr.io/kubeflow/notebooks/notebook-controller
+  IMG: ghcr.io/abdallahsamabd/notebooks/notebook-controller
   ARCH: linux/amd64,linux/ppc64le,linux/arm64/v8
 
 jobs:

.github/workflows/nb_controller_integration_test.yaml

@@ -1,20 +1,19 @@
 name: Notebook Controller Integration Test
 on:
-  pull_request:
+  push:
     paths:
       - components/notebook-controller/**
       - releasing/version/VERSION
     branches:
-      - main
-      - notebooks-v1
+      - feat/721
       - v*-branch
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event.number }}
   cancel-in-progress: true
 
 env:
-  IMG: ghcr.io/kubeflow/notebooks/notebook-controller
+  IMG: ghcr.io/abdallahsamabd/notebooks/notebook-controller
   TAG: integration-test
 
 jobs:

.github/workflows/nb_controller_multi_arch_test.yaml

@@ -1,20 +1,19 @@
 name: Notebook Controller Multi-Arch Build Test
 on:
-  pull_request:
+  push:
     paths:
       - components/notebook-controller/**
       - releasing/version/VERSION
     branches:
-      - main
-      - notebooks-v1
+      - feat/721
       - v*-branch
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event.number }}
   cancel-in-progress: true
 
 env:
-  IMG: ghcr.io/kubeflow/notebooks/notebook-controller
+  IMG: ghcr.io/abdallahsamabd/notebooks/notebook-controller
 
 jobs:
   build:

.github/workflows/nb_controller_unit_test.yaml

@@ -1,12 +1,11 @@
 name: Run Notebook Controller unit tests
 on:
-  pull_request:
+  push:
     paths:
       - components/notebook-controller/**
       - releasing/version/VERSION
     branches:
-      - main
-      - notebooks-v1
+      - feat/721
       - v*-branch
 
 jobs:
@@ -19,7 +18,7 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: "1.17"
+        go-version: "1.24"
         check-latest: true
 
     - name: Run unit tests

.github/workflows/tb_controller_docker_publish.yaml

@@ -2,15 +2,14 @@ name: Build & Publish Tensorboard Controller Docker image
 on:
   push:
     branches:
-      - main
-      - notebooks-v1
+      - feat/721
       - v*-branch
     paths:
       - components/tensorboard-controller/**
       - releasing/version/VERSION
 
 env:
-  IMG: ghcr.io/kubeflow/notebooks/tensorboard-controller
+  IMG: ghcr.io/abdallahsamabd/notebooks/tensorboard-controller
   ARCH: linux/amd64,linux/ppc64le,linux/arm64/v8
 
 jobs:

components/notebook-controller/Dockerfile

@@ -4,7 +4,7 @@
 #
 # ${PATH_TO_KUBEFLOW/KUBEFLOW repo}/components
 #
-ARG GOLANG_VERSION=1.17
+ARG GOLANG_VERSION=1.24
 FROM golang:${GOLANG_VERSION} as builder
 
 WORKDIR /workspace
@@ -16,6 +16,14 @@ COPY notebook-controller /workspace/notebook-controller
 # and so that source changes don't invalidate our downloaded layer
 RUN cd /workspace/notebook-controller && go mod download
 
+# Force download and extract all HashiCorp modules so they exist under /go/pkg/mod
+RUN set -e; cd /workspace/notebook-controller; \
+  for m in $(go list -m all | awk '/^github.com\/hashicorp\// {print $1 "@" $2}'); do \
+    go mod download "$m"; \
+    pkg="${m%@*}"; \
+    go list "$pkg/..." >/dev/null 2>&1 || true; \
+  done
+
 WORKDIR /workspace/notebook-controller
 
 # Build

components/notebook-controller/Makefile

@@ -136,7 +136,7 @@ undeploy: ## Undeploy controller from the K8s cluster specified in ~/.kube/confi
 CONTROLLER_GEN = $(shell pwd)/bin/controller-gen
 .PHONY: controller-gen
 controller-gen: ## Download controller-gen locally if necessary.
-	$(call go-get-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen@v0.8.0)
+	$(call go-get-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen@v0.14.0)
 
 KUSTOMIZE = $(shell pwd)/bin/kustomize
 .PHONY: kustomize

components/notebook-controller/go.mod

@@ -1,6 +1,6 @@
 module github.com/kubeflow/kubeflow/components/notebook-controller
 
-go 1.17
+go 1.24
 
 require (
 	github.com/go-logr/logr v1.2.0