fixing test report notifications

Signed-off-by: Nelesh Singla <[email protected]>

Author: nsingla

.github/actions/test-and-report/action.yml

@@ -145,6 +145,13 @@ runs:
         retention-days: 30
       continue-on-error: true
 
+    - name: Notify Test Report
+      id: notify
+      if: (!cancelled())
+      shell: bash
+      run: |
+        echo "::notice file=${{ inputs.test_directory }}/reports/test-report.html,title=${{ steps.name_gen.outputs.REPORT_NAME }}::${{ steps.name_gen.outputs.REPORT_NAME }} Report"
+
     - name: Mark Workflow failure if test step failed
       if: steps.run-tests.outcome != 'success' && !cancelled()
       shell: bash

.github/workflows/api-server-tests.yml

@@ -153,13 +153,6 @@ jobs:
           tls_enabled: ${{ matrix.pod_to_pod_tls_enabled }}
           ca_cert_path: ${{ env.CA_CERT_PATH }}
 
-      - name: Notify test reports
-        shell: bash
-        if: ${{ steps.test-run.outcome == 'success' }}
-
-        run: |
-          echo "::notice title=Test Summary and HTML Report is now available in the Summary Tab"
-
 
   api-test-k8s-native:
     needs: build
@@ -222,13 +215,6 @@ jobs:
           python_version: ${{ env.PYTHON_VERSION }}
           report_name: "K8Native_k8sVersion=${{ matrix.k8s_version }}_cacheEnabled=${{ matrix.cache_enabled }}_argoVersion=${{ matrix.argo_version }}_uploadPipelinesWithKubernetesClient=${{ matrix.uploadPipelinesWithKubernetesClient }}"
 
-      - name: Notify test reports
-        shell: bash
-        if: ${{ steps.test-run.outcome == 'success' }}
-        run: |
-          echo "::notice title=Test Summary and HTML Report is now available in the Summary Tab"
-
-
   api-test-multi-user:
     needs: build
     runs-on: ubuntu-latest
@@ -281,9 +267,3 @@ jobs:
           user_namespace: ${{ env.USER_NAMESPACE }}
           multi_user: ${{ matrix.multi_user }}
           report_name: "MultiUser_k8sVersion=${{ matrix.k8s_version }}_cacheEnabled=${{ matrix.cache_enabled }}_multiUser=${{ matrix.multi_user }}"
-
-      - name: Notify test reports
-        shell: bash
-        if: ${{ steps.test-run.outcome == 'success' }}
-        run: |
-          echo "::notice title=Test Summary and HTML Report is now available in the Summary Tab"

.github/workflows/e2e-test.yml

@@ -159,12 +159,6 @@ jobs:
           tls_enabled: ${{ matrix.pod_to_pod_tls_enabled }}
           ca_cert_path: ${{ env.CA_CERT_PATH }}
 
-      - name: Notify test reports
-        shell: bash
-        if: ${{ steps.test-run.outcome == 'success' }}
-        run: |
-          echo "::notice title=Test Summary and HTML Report is now available in the Summary Tab"
-
   end-to-end-critical-scenario-multi-user-tests:
     runs-on: ubuntu-latest
     needs: build
@@ -264,9 +258,3 @@ jobs:
           python_version: ${{ env.PYTHON_VERSION }}
           user_namespace: ${{ env.USER_NAMESPACE }}
           report_name: "E2EMultiUserTests_K8s=${{ matrix.k8s_version }}_cacheEnabled=${{ matrix.cache_enabled }}_multiUser=${{ matrix.multi_user }}_storage=${{ matrix.storage }}"
-
-      - name: Notify test reports
-        shell: bash
-        if: ${{ steps.test-run.outcome == 'success' }}
-        run: |
-          echo "::notice title=Test Summary and HTML Report is now available in the Summary Tab"

.github/workflows/upgrade-test.yml

@@ -2,8 +2,7 @@ name: KFP upgrade tests
 
 env:
   TESTS_DIR: "./backend/test/v2/api"
-  TESTS_LABEL: "ApiServerTests"
-  NUMBER_OF_PARALLEL_NODES: 15
+  NUMBER_OF_PARALLEL_NODES: 10
   CLUSTER_NAME: "kfp"
   NAMESPACE: "kubeflow"
   PYTHON_VERSION: "3.9"
@@ -92,6 +91,11 @@ jobs:
           go run github.com/onsi/ginkgo/v2/ginkgo -r -v --cover -p --keep-going --github-output=true --nodes=${{ env.NUMBER_OF_PARALLEL_NODES }} -v --label-filter="UpgradePreparation"
         continue-on-error: true
 
+      - name: Stop port forwarding
+        run: |
+          pkill -f "port-forward"
+        continue-on-error: true
+
       - name: Deploy from Branch
         uses: ./.github/actions/deploy
         if: ${{ steps.create-cluster.outcome == 'success' }}
@@ -100,16 +104,15 @@ jobs:
           image_path: ${{ needs.build.outputs.IMAGE_PATH }}
           image_tag: ${{ needs.build.outputs.IMAGE_TAG }}
           image_registry: ${{ needs.build.outputs.IMAGE_REGISTRY }}
-          forward_port: 'false'
-
-# The step below has been temporarily removed as it consistently fails.
-#      - name: Verify Upgrade
-#        uses: ./.github/actions/test-and-report
-#        if: ${{ steps.deploy.outcome == 'success' }}
-#        with:
-#          test_directory: ${{ env.TESTS_DIR }}
-#          test_label: "UpgradeVerification"
-#          num_parallel_nodes: ${{ env.NUMBER_OF_PARALLEL_NODES }}
-#          default_namespace: ${{ env.NAMESPACE }}
-#          python_version: ${{ env.PYTHON_VERSION }}
-#          report_name: "Upgrade Verification"
+          forward_port: 'true'
+
+      - name: Verify Upgrade
+        uses: ./.github/actions/test-and-report
+        if: ${{ steps.deploy.outcome == 'success' }}
+        with:
+          test_directory: ${{ env.TESTS_DIR }}
+          test_label: "UpgradeVerification"
+          num_parallel_nodes: ${{ env.NUMBER_OF_PARALLEL_NODES }}
+          default_namespace: ${{ env.NAMESPACE }}
+          python_version: ${{ env.PYTHON_VERSION }}
+          report_name: "Upgrade Verification"