Add MXJob v1 api and controller#1296
Add MXJob v1 api and controller#1296google-oss-robot merged 1 commit intokubeflow:all-in-one-operatorfrom
Conversation
Jeffwan
requested review from
terrytangyuan and
zw0610
and removed request for
jinchihe and
terrytangyuan
|
/cc @kubeflow/wg-training-leads |
- Generate MXJob api and manifests - Rewrite MXNet controller logic in reconciler pattern Signed-off-by: Jiaxin Shan <[email protected]>
|
I just rebase the upstream and resolve the merge conflicts |
| bin/ | ||
| /tf-operator | ||
| vendor/ | ||
| testbin/* |
There was a problem hiding this comment.
Where is this being generated from?
There was a problem hiding this comment.
It's from make test command. https://github.com/kubeflow/tf-operator/blob/91ae0a8219085230d571f1c1df0808ca9b20d09e/Makefile#L52-L56
command automatically creates ./testbin
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan, terrytangyuan, zw0610 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
part of kubeflow/common#138 #1298 |
- Generate MXJob api and manifests - Rewrite MXNet controller logic in reconciler pattern Signed-off-by: Jiaxin Shan <[email protected]>
4 participants
Signed-off-by: Jiaxin Shan [email protected]