fix: delete all ips before deleting a subnet #5775
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbb88888
reviewed
Oct 9, 2025
| metav1.DeleteOptions{PropagationPolicy: &deletePolicy}, | ||
| ); err != nil && !k8serrors.IsNotFound(err) { | ||
| klog.Errorf("failed to delete ip %s: %v", ip.Name, err) | ||
| return err |
There was a problem hiding this comment.
how about just logging error and continue?
There was a problem hiding this comment.
Yeah, sorry about this confusion. I will put together a more thorough PR description today. Basically, the issue is that IPs aren't getting deleted before their subnets, so when the controller goes to remove the finalizer, and the subnet doesn't exist, it fails and doesn't remove the finalizer, and it never proceeds. I forgot I made a draft PR with my changes, and this will not be the final version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)
Additional details
When a Subnet CR is created with one or more IP CRs, and then the resources are eventually deleted, instances where the subnet is deleted before the finalizers are removed from the IPs cause a failure, and the IPs are left unable to be deleted due to the absence of the corresponding Subnet. With kube-ovn being heavily reliant on the ability for these resources to be able to be deleted simultaneously, this seems to be counterintuitive to that philosophy.