Fix ip not count

[zbb88888]

Pull Request

• Make sure you have followed Kube-OVN Code Style.

What type of this PR

Examples of user facing changes:

• Bug fixes

the same as: #5733

split ip and LSP

Which issue(s) this PR fixes

Fixes #(issue-number)

[gemini-code-assist]

Summary of Changes

Hello @zbb88888, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug related to IP counting by refining the logic for how and when subnet status updates are triggered in the IP and EIP controllers. The changes ensure that IP counts are accurately reflected by moving status update enqueues to more appropriate points in the lifecycle of IP and EIP resources, preventing potential miscounts or stale status information.

Highlights

• IP Status Update Logic Refinement: The logic for enqueuing subnet status updates related to IP address changes has been refactored. Previously, these updates were triggered during IP enqueue operations; now, they are explicitly called after an IP is successfully added or reserved, ensuring more accurate status reflection.
• Reserved IP Handling Simplification: The handleAddReservedIP function has been simplified by removing checks for existing Logical Switch Ports (LSPs) and port name validation, streamlining the process for handling reserved IP addresses.
• EIP Status Update Adjustment: The mechanism for updating subnet status when an Elastic IP (EIP) is updated or added has been adjusted. The updateSubnetStatusQueue is now explicitly called after an EIP is successfully added, rather than during the EIP enqueue process.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly refactors the IP counting logic by moving the subnet status updates to the end of the handler functions. This ensures that the IP usage count is updated only after an IP or EIP has been successfully processed, making the counting more reliable. The removal of the early-exit logic in handleAddReservedIP is a key fix that prevents state inconsistencies when a logical switch port already exists. However, there is a minor regression in vpc_nat_gw_eip.go where the subnet status is not updated promptly upon EIP deletion, which I've commented on.

[zbb88888]

@oilbeater 和之前 mc 分支的那个 PR 一样

[oilbeater]

@zbb88888 看上去不少相关的 e2e 出问题了

[zbb88888]

@zbb88888 看上去不少相关的 e2e 出问题了

是的 我周末再检查下