Skip to content

Conversation

@6ixfalls
Copy link

Pull Request

What type of this PR

Examples of user facing changes:

  • Features

Allows the tag for the vpcRepository image (vpc-nat-gateway) to be overriden. Useful when the image tags are using digest references, since the tag for the kubeovn image can't be reused for vpc-nat-gateway.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 31, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @6ixfalls, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Helm charts for Kube-OVN by providing a dedicated configuration option to specify the image tag for the vpc-nat-gateway component. This change addresses scenarios where the vpc-nat-gateway image might require a different tag than the main kubeovn image, such as when using digest references, thereby increasing flexibility in image management and deployment.

Highlights

  • New Configuration Option: Introduced a new vpcTag parameter within the global.images.kubeovn section of the values.yaml files for both kube-ovn and kube-ovn-v2 Helm charts. This allows explicit control over the vpc-nat-gateway image tag.
  • Image Tag Resolution Logic: Modified the vpc-nat-config.yaml templates to prioritize the newly introduced vpcTag for the vpc-nat-gateway image. If vpcTag is not specified (or empty), it gracefully falls back to using the general tag value defined for kubeovn.
  • Documentation Update: The README.md for kube-ovn-v2 has been updated to include the vpcTag in the image configuration example, improving clarity for users regarding this new option.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added chart Helm Chart feature New network feature labels Oct 31, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new vpcTag value to allow overriding the image tag for the vpc-nat-gateway, which is useful for digest-based image references. The implementation is correct, using the Helm or function as a fallback to the existing tag value across both kube-ovn and kube-ovn-v2 charts. The associated documentation and default values have also been updated accordingly. I've noted one minor issue regarding an unrelated documentation change that should ideally be in a separate PR to keep the history clean.

Comment on lines +1516 to +1524
<tr>
<td>networking.skipConntrackDstCidrs</td>
<td>string</td>
<td><pre lang="json">
""
</pre>
</td>
<td>Comma-separated list of destination IP CIDRs that should skip conntrack processing.</td>
</tr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This documentation change for networking.skipConntrackDstCidrs seems unrelated to the main purpose of this pull request, which is to allow specifying vpcTag. To maintain a clean and focused commit history, it's generally better to submit unrelated changes in separate pull requests. Please consider moving this change to a separate PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran helm-docs to regenerate the chart README - that wasn't added from a prior commit by someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chart Helm Chart feature New network feature size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant