-
Notifications
You must be signed in to change notification settings - Fork 494
feat: allow vpcTag to be specified to override tag #5845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @6ixfalls, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Helm charts for Kube-OVN by providing a dedicated configuration option to specify the image tag for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Signed-off-by: Six <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new vpcTag value to allow overriding the image tag for the vpc-nat-gateway, which is useful for digest-based image references. The implementation is correct, using the Helm or function as a fallback to the existing tag value across both kube-ovn and kube-ovn-v2 charts. The associated documentation and default values have also been updated accordingly. I've noted one minor issue regarding an unrelated documentation change that should ideally be in a separate PR to keep the history clean.
| <tr> | ||
| <td>networking.skipConntrackDstCidrs</td> | ||
| <td>string</td> | ||
| <td><pre lang="json"> | ||
| "" | ||
| </pre> | ||
| </td> | ||
| <td>Comma-separated list of destination IP CIDRs that should skip conntrack processing.</td> | ||
| </tr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This documentation change for networking.skipConntrackDstCidrs seems unrelated to the main purpose of this pull request, which is to allow specifying vpcTag. To maintain a clean and focused commit history, it's generally better to submit unrelated changes in separate pull requests. Please consider moving this change to a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran helm-docs to regenerate the chart README - that wasn't added from a prior commit by someone else.
Pull Request
What type of this PR
Examples of user facing changes:
Allows the tag for the vpcRepository image (vpc-nat-gateway) to be overriden. Useful when the image tags are using digest references, since the tag for the kubeovn image can't be reused for vpc-nat-gateway.