-
Notifications
You must be signed in to change notification settings - Fork 543
IntOrString type broke in 0.16.2 #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Weird, not sure what happened here, but I will fix it. |
Ok, apologies for the delay. It looks like when the 0.16.1 was generated the #774 has that fix and the fixed generated code too. |
@pascal-cloudnatix once that PR is merged, I will cut an Thanks! |
|
Thanks so much Brendan 🙏 |
Describe the bug
It seems that in the latest tag 0.16.2
intOrString
type is broken again. In the 0.16.1 tag the IntOrString type was fixed.Related issues:
Seems like this commit 1f79306 undid the work done in this commit d44fa64
** Client Version **
0.16.2
To Reproduce
@kubernetes/client-node/dist/gen/model/v1PodDisruptionBudgetSpec.d.ts
V1PodDisruptionBudgetSpec should look like this:
@kubernetes/client-node/dist/gen/model/v1PodDisruptionBudgetSpec.d.ts
V1PodDisruptionBudgetSpec now looks like this, which removes the fixed type in 0.16.1
Expected behavior
Generated type should be:
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: