Skip to content

IntOrString type broke in 0.16.2 #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pascal-cloudnatix opened this issue Jan 29, 2022 · 5 comments · Fixed by #774
Closed

IntOrString type broke in 0.16.2 #771

pascal-cloudnatix opened this issue Jan 29, 2022 · 5 comments · Fixed by #774

Comments

@pascal-cloudnatix
Copy link

pascal-cloudnatix commented Jan 29, 2022

Describe the bug
It seems that in the latest tag 0.16.2 intOrString type is broken again. In the 0.16.1 tag the IntOrString type was fixed.
Related issues:

Seems like this commit 1f79306 undid the work done in this commit d44fa64

** Client Version **
0.16.2

To Reproduce

  1. Install version 0.16.1 and check file @kubernetes/client-node/dist/gen/model/v1PodDisruptionBudgetSpec.d.ts
    V1PodDisruptionBudgetSpec should look like this:
export declare class V1PodDisruptionBudgetSpec {
    'maxUnavailable'?: IntOrString;
    'minAvailable'?: IntOrString;
}
  1. Install version 0.16.2 and check file @kubernetes/client-node/dist/gen/model/v1PodDisruptionBudgetSpec.d.ts
    V1PodDisruptionBudgetSpec now looks like this, which removes the fixed type in 0.16.1
export declare class V1PodDisruptionBudgetSpec {
    'maxUnavailable'?: object;
    'minAvailable'?: object;
}

Expected behavior
Generated type should be:

export declare class V1PodDisruptionBudgetSpec {
    'maxUnavailable'?: IntOrString;
    'minAvailable'?: IntOrString;
}

Environment (please complete the following information):

  • OS: MacOs
  • NodeJS Version 16
@brendandburns
Copy link
Contributor

Weird, not sure what happened here, but I will fix it.

@brendandburns
Copy link
Contributor

Ok, apologies for the delay. It looks like when the 0.16.1 was generated the settings file changes were not checked in.

#774 has that fix and the fixed generated code too.

@brendandburns
Copy link
Contributor

@pascal-cloudnatix once that PR is merged, I will cut an 0.16.3 release. If you could give it a quick review that will speed things up.

Thanks!

@brendandburns
Copy link
Contributor

0.16.3 has been pushed out to NPM.

@pascal-cloudnatix
Copy link
Author

Thanks so much Brendan 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants