-
Notifications
You must be signed in to change notification settings - Fork 151
Open
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.
Description
This test specifically checks for "existing volumes" by doing a ListVolumes
call then afterwards does removing all listed volumes
This means that this test could removes all volumes listed even if the volume was not created by this test. This could cause data loss depending on how a consumer is using CSI sanity.
This brings up a larger problem I have with this test too - either
- You are consuming csi-sanity and mocking out the back-end (this is what I do) -> this test is way too complicated and depends on the workings of pagination and doesn't feel like a simple "sanity test" like the rest of the package
- You are not mocking out the backend -> this test has potential for data loss
Metadata
Metadata
Assignees
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.