distributed provisioning: dedicated check for "incompatible topology"

[pohly]

As discussed in #612 (comment), the usage of GenerateAccessibilityRequirements in the following code could be improved:
https://github.com/pohly/external-provisioner/blob/f262e0f93ce2c172ac22f54978bbb9aff7f59d21/pkg/controller/controller.go#L1296-L1320

It works because the function is expected to only fail when the storage class topology is not compatible with the current node, but that is not obvious.

Options to make it more obvious:

• split out relevant code from GenerateAccessibilityRequirements which checks the topology or
• add an error code for "not compatible" to GenerateAccessibilityRequirements and check for that

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[pohly]

/remove-lifecycle stale
/asssign

[pohly]

/assign

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[pohly]

/remove-lifecycle stale
/lifecycle frozen