Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LoadBalancerSourceRanges for UDP #88

Open
aojea opened this issue Jun 4, 2024 · 4 comments
Open

Implement LoadBalancerSourceRanges for UDP #88

aojea opened this issue Jun 4, 2024 · 4 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@aojea
Copy link
Contributor

aojea commented Jun 4, 2024

          maybe fixed, but only for TCP because I couldn't figure out for sure where to add it for UDP

Originally posted by @danwinship in #80 (comment)

This require some knowledge of envoy, as a guidance people can use the linked PR above

@aojea aojea added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 4, 2024
@danwinship
Copy link
Contributor

Note that whoever implements this probably needs to add an e2e test to kubernetes for it too 🙂

@THUzxj
Copy link

THUzxj commented Jul 23, 2024

Hi, I'd like to work on this. As far as I understand, I should add source_prefix_ranges (or templates with the same function) to the UDP branch of proxyLDSConfigTemplate, and the tests of UDP are very similar to those of TCP (just replace TCP with UDP). Please figure out if I misunderstand.
However, I am unclear on how to run the e2e test in the Kubernetes repo with cloud-provider-kind. I'd appreciate it if you could give me some instructions.

@aojea
Copy link
Contributor Author

aojea commented Jul 23, 2024

This script can serve you as guide to run the e2e tests https://github.com/kubernetes-sigs/cloud-provider-kind/blob/main/hack/ci/e2e.sh and more info in kubernetes-sigs/kind#1181 (comment)

@danwinship
Copy link
Contributor

As far as I understand, I should add source_prefix_ranges (or templates with the same function) to the UDP branch of proxyLDSConfigTemplate

It's been a while since I looked at this, but IIRC, there was no obvious way to just copy the approach we used for TCP into the UDP config. The right options didn't seem to be available? You'll probably have to dig into the envoy documentation a bit...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants