Merge pull request #5437 from gofogo/paasops-6-dupword-v0

chore(codebase): enable dupword linter

Author: k8s-ci-robot

.golangci.yml

@@ -4,7 +4,8 @@ linters:
   default: none
   enable: # golangci-lint help linters
     - copyloopvar # A linter detects places where loop variables are copied. https://golangci-lint.run/usage/linters/#copyloopvar
-    - dogsled
+    - dogsled # Checks assignments with too many blank identifiers. https://golangci-lint.run/usage/linters/#dogsled
+    - dupword # Duplicate word. https://golangci-lint.run/usage/linters/#dupword
     - goprintffuncname
     - govet
     - ineffassign

docs/flags.md

@@ -133,7 +133,7 @@
 | `--exoscale-apizone="ch-gva-2"` | When using Exoscale provider, specify the API Zone (optional) |
 | `--exoscale-apikey=""` | Provide your API Key for the Exoscale provider |
 | `--exoscale-apisecret=""` | Provide your API Secret for the Exoscale provider |
-| `--rfc2136-host=` | When using the RFC2136 provider, specify the host of the DNS server (optionally specify multiple times when when using --rfc2136-load-balancing-strategy) |
+| `--rfc2136-host=` | When using the RFC2136 provider, specify the host of the DNS server (optionally specify multiple times when using --rfc2136-load-balancing-strategy) |
 | `--rfc2136-port=0` | When using the RFC2136 provider, specify the port of the DNS server |
 | `--rfc2136-zone=RFC2136-ZONE` | When using the RFC2136 provider, specify zone entry of the DNS server to use (can be specified multiple times) |
 | `--[no-]rfc2136-create-ptr` | When using the RFC2136 provider, enable PTR management |

endpoint/crypto_test.go

@@ -45,7 +45,7 @@ func TestEncrypt(t *testing.T) {
 		t.Error("Data decryption failed, empty string should be as result")
 	}
 
-	// Verify that decrypt returns an error and empty data if unencrypted input is is supplied
+	// Verify that decrypt returns an error and empty data if unencrypted input is supplied
 	decryptedtext, _, err = DecryptText(plaintext, aesKey)
 	require.Error(t, err)
 	if decryptedtext != "" {

pkg/apis/externaldns/types.go

@@ -587,7 +587,7 @@ func App(cfg *Config) *kingpin.Application {
 	app.Flag("exoscale-apisecret", "Provide your API Secret for the Exoscale provider").Default(defaultConfig.ExoscaleAPISecret).StringVar(&cfg.ExoscaleAPISecret)
 
 	// Flags related to RFC2136 provider
-	app.Flag("rfc2136-host", "When using the RFC2136 provider, specify the host of the DNS server (optionally specify multiple times when when using --rfc2136-load-balancing-strategy)").Default(defaultConfig.RFC2136Host[0]).StringsVar(&cfg.RFC2136Host)
+	app.Flag("rfc2136-host", "When using the RFC2136 provider, specify the host of the DNS server (optionally specify multiple times when using --rfc2136-load-balancing-strategy)").Default(defaultConfig.RFC2136Host[0]).StringsVar(&cfg.RFC2136Host)
 	app.Flag("rfc2136-port", "When using the RFC2136 provider, specify the port of the DNS server").Default(strconv.Itoa(defaultConfig.RFC2136Port)).IntVar(&cfg.RFC2136Port)
 	app.Flag("rfc2136-zone", "When using the RFC2136 provider, specify zone entry of the DNS server to use (can be specified multiple times)").StringsVar(&cfg.RFC2136Zone)
 	app.Flag("rfc2136-create-ptr", "When using the RFC2136 provider, enable PTR management").Default(strconv.FormatBool(defaultConfig.RFC2136CreatePTR)).BoolVar(&cfg.RFC2136CreatePTR)

provider/ns1/ns1.go

@@ -44,7 +44,7 @@ const (
 	defaultTTL = 10
 )
 
-// NS1DomainClient is a subset of the NS1 API the the provider uses, to ease testing
+// NS1DomainClient is a subset of the NS1 API the provider uses, to ease testing
 type NS1DomainClient interface {
 	CreateRecord(r *dns.Record) (*http.Response, error)
 	DeleteRecord(zone string, domain string, t string) (*http.Response, error)

provider/rfc2136/rfc2136_test.go

@@ -600,7 +600,7 @@ func TestRfc2136ApplyChanges(t *testing.T) {
 }
 
 // These tests all use the foo.com and foobar.com zones with no filters
-// createMsgs and updateMsgs need sorted when are are used
+// createMsgs and updateMsgs need sorted when are used
 func TestRfc2136ApplyChangesWithZones(t *testing.T) {
 	stub := newStub()
 	provider, err := createRfc2136StubProviderWithZones(stub)
@@ -664,7 +664,7 @@ func TestRfc2136ApplyChangesWithZones(t *testing.T) {
 }
 
 // These tests use the foo.com and foobar.com zones and with filters set to both zones
-// createMsgs and updateMsgs need sorted when are are used
+// createMsgs and updateMsgs need sorted when are used
 func TestRfc2136ApplyChangesWithZonesFilters(t *testing.T) {
 	stub := newStub()
 	provider, err := createRfc2136StubProviderWithZonesFilters(stub)

provider/transip/transip.go

@@ -97,7 +97,7 @@ func (p *TransIPProvider) ApplyChanges(ctx context.Context, changes *plan.Change
 	// refresh zone mapping
 	zoneMap := provider.ZoneIDName{}
 	for _, zone := range zones {
-		// TransIP API doesn't expose a unique identifier for zones, other than than
+		// TransIP API doesn't expose a unique identifier for zones, other than
 		// the domain name itself
 		zoneMap.Add(zone.Name, zone.Name)
 	}

provider/transip/transip_test.go

@@ -238,7 +238,7 @@ func TestProviderRecords(t *testing.T) {
 		switch {
 		case req.Endpoint == "/domains":
 			// return list of some domain names
-			// names only, other fields are not used
+			// only, other fields are not used
 			data = []byte(`{"domains":[{"name":"example.org"}, {"name":"example.com"}]}`)
 		case strings.HasSuffix(req.Endpoint, "/dns"):
 			// return list of DNS entries