Skip to content

Commit 881fef5

Browse files
committed
fix: Allow revisionHistoryLimit to be set to 0
Signed-off-by: Matt Dainty <[email protected]>
1 parent e1adc90 commit 881fef5

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

Diff for: charts/external-dns/templates/deployment.yaml

+1-3
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@ spec:
1616
{{- include "external-dns.selectorLabels" . | nindent 6 }}
1717
strategy:
1818
{{- toYaml .Values.deploymentStrategy | nindent 4 }}
19-
{{- with .Values.revisionHistoryLimit }}
20-
revisionHistoryLimit: {{ . }}
21-
{{- end }}
19+
revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
2220
template:
2321
metadata:
2422
labels:

Diff for: charts/external-dns/values.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,8 @@ secretConfiguration:
197197
deploymentStrategy:
198198
type: Recreate
199199

200-
# Optional field that specifies the number of old ReplicaSets to retain to allow rollback with the Deployment.
201-
revisionHistoryLimit:
200+
# Specifies the number of old ReplicaSets to retain to allow rollback with the Deployment.
201+
revisionHistoryLimit: 10
202202

203203
# opt out of the service account token automounting (at the pod level)
204204
automountServiceAccountToken:

0 commit comments

Comments
 (0)