Skip to content

Commit 8a64700

Browse files
authored
Merge pull request #4189 from kubernetes-sigs/test/plan-should-detect-no-change-with-provider-specific-config
test: detect no change necessary with provider specific config
2 parents c506a20 + 99626ee commit 8a64700

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

plan/plan_test.go

+17
Original file line numberDiff line numberDiff line change
@@ -355,6 +355,23 @@ func (suite *PlanTestSuite) TestSyncSecondRoundWithProviderSpecificChange() {
355355
validateEntries(suite.T(), changes.Delete, expectedDelete)
356356
}
357357

358+
func (suite *PlanTestSuite) TestSyncSecondRoundWithProviderSpecificNoChange() {
359+
current := []*endpoint.Endpoint{suite.bar127AWithProviderSpecificTrue}
360+
desired := []*endpoint.Endpoint{suite.bar127AWithProviderSpecificTrue}
361+
362+
p := &Plan{
363+
Policies: []Policy{&SyncPolicy{}},
364+
Current: current,
365+
Desired: desired,
366+
ManagedRecords: []string{endpoint.RecordTypeA, endpoint.RecordTypeCNAME},
367+
}
368+
369+
changes := p.Calculate().Changes
370+
if changes.HasChanges() {
371+
suite.T().Fatal("test should not have changes")
372+
}
373+
}
374+
358375
func (suite *PlanTestSuite) TestSyncSecondRoundWithProviderSpecificRemoval() {
359376
current := []*endpoint.Endpoint{suite.bar127AWithProviderSpecificFalse}
360377
desired := []*endpoint.Endpoint{suite.bar127AWithProviderSpecificUnset}

0 commit comments

Comments
 (0)