Skip to content

Commit b9c761d

Browse files
committed
fix: Allow revisionHistoryLimit to be set to 0
Signed-off-by: Matt Dainty <[email protected]>
1 parent 25f8242 commit b9c761d

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

Diff for: charts/external-dns/templates/deployment.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ spec:
1616
{{- include "external-dns.selectorLabels" . | nindent 6 }}
1717
strategy:
1818
{{- toYaml .Values.deploymentStrategy | nindent 4 }}
19-
{{- with .Values.revisionHistoryLimit }}
20-
revisionHistoryLimit: {{ . }}
19+
{{- if or (kindIs "float64" .Values.revisionHistoryLimit) (kindIs "int64" .Values.revisionHistoryLimit) }}
20+
revisionHistoryLimit: {{ .Values.revisionHistoryLimit | int64 }}
2121
{{- end }}
2222
template:
2323
metadata:

Diff for: charts/external-dns/values.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -228,3 +228,6 @@ secretConfiguration:
228228
subPath:
229229
# -- `Secret` data.
230230
data: {}
231+
232+
# Specifies the number of old ReplicaSets to retain to allow rollback with the Deployment.
233+
revisionHistoryLimit:

0 commit comments

Comments
 (0)