Skip to content

Commit f46676f

Browse files
authored
Merge pull request #4488 from morremeyer/fix/api-approved-annotation
fix: re-add api-approved.kubernetes.io annotation
2 parents 7d12b63 + c0a183b commit f46676f

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

Makefile

+1-5
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,7 @@ controller-gen:
3333
ifeq (, $(shell which controller-gen))
3434
@{ \
3535
set -e ;\
36-
CONTROLLER_GEN_TMP_DIR=$$(mktemp -d) ;\
37-
cd $$CONTROLLER_GEN_TMP_DIR ;\
38-
go mod init tmp ;\
39-
go get sigs.k8s.io/controller-tools/cmd/[email protected] ;\
40-
rm -rf $$CONTROLLER_GEN_TMP_DIR ;\
36+
go install sigs.k8s.io/controller-tools/cmd/[email protected] ;\
4137
}
4238
CONTROLLER_GEN=$(GOBIN)/controller-gen
4339
else

docs/contributing/crd-source/crd-manifest.yaml

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ apiVersion: apiextensions.k8s.io/v1
33
kind: CustomResourceDefinition
44
metadata:
55
annotations:
6-
controller-gen.kubebuilder.io/version: v0.14.0
6+
api-approved.kubernetes.io: https://github.com/kubernetes-sigs/external-dns/pull/2007
7+
controller-gen.kubebuilder.io/version: v0.15.0
78
name: dnsendpoints.externaldns.k8s.io
89
spec:
910
group: externaldns.k8s.io

endpoint/endpoint.go

+1
Original file line numberDiff line numberDiff line change
@@ -357,6 +357,7 @@ type DNSEndpointStatus struct {
357357
// +kubebuilder:resource:path=dnsendpoints
358358
// +kubebuilder:object:root=true
359359
// +kubebuilder:subresource:status
360+
// +kubebuilder:metadata:annotations="api-approved.kubernetes.io=https://github.com/kubernetes-sigs/external-dns/pull/2007"
360361
// +versionName=v1alpha1
361362

362363
type DNSEndpoint struct {

0 commit comments

Comments
 (0)