Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Request: Webhook Support for Endpoint Sources #4445

Closed
sleyva-jumptrading opened this issue May 7, 2024 · 5 comments
Closed

Feat Request: Webhook Support for Endpoint Sources #4445

sleyva-jumptrading opened this issue May 7, 2024 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@sleyva-jumptrading
Copy link

sleyva-jumptrading commented May 7, 2024

What would you like to be added:

Similar to DNS providers, external-dns also maintains a list of sources for endpoints. This proposal is to move DNS sources to a webhook based approach similar to providers. This attempts to solve a similar problem to #4347 just for Endpoint sources as well.

Why is this needed:

The ability to integrate with a generic external API via a webhook would significantly enhance the flexibility and utility of External DNS Sources. This feature would enable the system to interact with various external services more dynamically and would reduce the amount of code needed to be maintained in external-dns for various sources (istio gateways, Virtual Services, etc). It could also potentially increase the adoption and versatility of the tool by accommodating different types of external data sources.

@sleyva-jumptrading sleyva-jumptrading added the kind/feature Categorizes issue or PR as related to a new feature. label May 7, 2024
@szuecs
Copy link
Contributor

szuecs commented May 11, 2024

There was also a problem with gateway-api. They have 2 alpha resources that are not available anymore and it blocks our dependency upgrade @Raffo .

I posted this to gateway api channel:

Somehow we need get better for breaking changes even if it's alpha resource #4455 shows:

# sigs.k8s.io/external-dns/source [sigs.k8s.io/external-dns/source.test]
Error: source/gateway_grpcroute_test.go:75:18: undefined: v1alpha2.GRPCRouteSpec
Error: source/gateway_grpcroute_test.go:78:20: undefined: v1alpha2.GRPCRouteStatus

I have no good idea right now how to handle this in good way such that alpha resources can iterate quickly without breaking us. One way could be a webhook for sources, I think.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 28, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 27, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2024
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants