-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Open
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/documentationCategorizes issue or PR as related to documentation.Categorizes issue or PR as related to documentation.sig/testingCategorizes an issue or PR as relevant to SIG Testing.Categorizes an issue or PR as relevant to SIG Testing.
Description
What would you like to be documented:
Fix wait for ingress script in https://kind.sigs.k8s.io/docs/user/ingress/#ingress-nginx
Why is this needed:
This is needed because with a slow internet connection and a slow computer
ingress-nginx-admission-create
and ingress-nginx-admission-patch
jobs take some time to complete.
While they are not completed the wait command provided in the documentation returns after a few seconds with
error: no matching resources found
This is because we first have to wait for ingress-nginx-admission-patch
to complete before waiting for the controller to be ready.
I would propose to add a first wait command to wait for the jobs to complete in this documentation under the nginx section :
{{< codeFromInline lang="bash" >}} kubectl wait --namespace ingress-nginx
--for=condition=complete job/ingress-nginx-admission-patch
--timeout=30s
&&
kubectl wait --namespace ingress-nginx
--for=condition=ready pod
--selector=app.kubernetes.io/component=controller
--timeout=90s {{< /codeFromInline >}}
anuruddhal and SaberStrathongbo-miao
Metadata
Metadata
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/documentationCategorizes issue or PR as related to documentation.Categorizes issue or PR as related to documentation.sig/testingCategorizes an issue or PR as relevant to SIG Testing.Categorizes an issue or PR as relevant to SIG Testing.