-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and update releng/test_config.yaml
#32340
Comments
/sig release |
/priority important-soon |
/milestone v1.31 |
@dims: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
We're running into this issue again ahead of the 1.31 jobs cut. These are the high priority issues at the moment:
/priority critical-urgent |
Yes, we should keep it. helps catch the scenario where
Yes, please. will help give us signal on an alpha feature https://github.com/kubernetes/kubernetes/blob/9413cf204ac92711cc8aff472b1ed11ba79760ac/pkg/features/kube_features.go#L261-L267
We can drop it, does not do much AFAICT looking through references - https://cs.k8s.io/?q=ENABLE_POD_SECURITY_POLICY%7CEnablePodSecurityPolicy&i=nope&files=&excludeFiles=vendor&repos= |
Can we please just use config fork annotations on normal prowjobs and stop using this other thing entirely? I don't think SIG release should be defining these jobs, just forking them when new branches are cut, and I really doubt anyone else in the project is looking at this file. It's hard to even understand what these config fields are doing. cc @liggitt @tallclair re: PSP yes we want to keep the cache mutation detector enabled. |
ENABLE_POD_SECURITY_POLICY is irrelevant in 1.25+ and can be dropped |
documented and widely used: https://github.com/kubernetes/test-infra/tree/master/releng/config-forker#supported-annotations Versus ~no docs for generate_tests and the out of band config. If the config fork annotations are not powerful enough for some reason, let's fix that. |
Long term, we can look into it. But short term and specially for this upcoming release, definitely no. We're happy to look into it, but this will require some time and we want to get the release branch up and running ASAP. |
I'm pretty sure https://kubernetes.slack.com/archives/CN0K3TE2C/p1722833073336809 is related The problem is that job maintainers are going to PR the job definitions and expect auto-forking, and are not aware that this out of band config needs changing as well, since it is only used once per release branch. I think we really need to switch for 1.32 or we'll keep having regressions. |
/assign |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
releng/test_config.yaml
contains definitions forkubernetes/kubernetes
tests (mainly periodics). We use those definitions to generate jobs for release branches when cutting a new release branch.Over the time, this file has become unmaintained which is a huge risk for having jobs that are not properly testing release branches.
Here are some problems that I observed; this is a non exhaustive list, in other words, there might be other issues that I didn't observe:
.jobs
ci-kubernetes-e2e-gce-cos-.+?-default
is inconsistentci-kubernetes-e2e-gce-cos-k8sbeta-default
has--env=ENABLE_CACHE_MUTATION_DETECTOR=true
argci-kubernetes-e2e-gce-cos-k8sstable1-default
has--env=ENABLE_POD_SECURITY_POLICY=true
ci-kubernetes-e2e-gce-cos-.+?-default
jobs have no (additional args)k8sbeta
andk8sstable1
jobs are missingtestgridNumFailuresToAlert
parameterbetaapis
tests fork8sbeta
,k8sstable1
, andk8sstable2
releasesbetaapis
tests are still valid.images
cos1
,cos2
,ubuntu1
, andubuntu2
images are not present in jobs names and therefore are likely unused (check if it is safe to remove these images).testSuites
flaky
,soak
,stackdriver
,updown
, andnosat
suites are not present in jobs names and therefore are likely unused (check if it is safe to remove these images).nodeImages
cos1
,cos2
,ubuntu1
, andubuntu2
images are not present in jobs names and therefore are likely unused (check if it is safe to remove these images).nodeTestSuites
gkespec
andserial
are likely unusedOnce these issues are addressed, we should verify if arguments are up to date for remaining test options.
cc @kubernetes/release-engineering @dims
The text was updated successfully, but these errors were encountered: