Skip to content

Commit a5d9f58

Browse files
committed
fix: avoid checking for latest release on GitHub with every CLI command
1 parent 8b26e37 commit a5d9f58

File tree

1 file changed

+12
-8
lines changed
  • cmd/kubectl-testkube/commands/docker

1 file changed

+12
-8
lines changed

cmd/kubectl-testkube/commands/docker/init.go

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"errors"
55
"fmt"
66
"os"
7+
"strings"
78

89
"github.com/pterm/pterm"
910
"github.com/spf13/cobra"
@@ -14,18 +15,15 @@ import (
1415
"github.com/kubeshop/testkube/pkg/ui"
1516
)
1617

18+
const (
19+
StableReleasePlaceholder = "<latest-stable-release>"
20+
)
21+
1722
func NewInitCmd() *cobra.Command {
1823
var noLogin bool // ignore ask for login
1924
var dockerContainerName, dockerImage string
2025
var options common.HelmOptions
2126

22-
latestVersion, err := common.GetLatestVersion()
23-
ui.ExitOnError("Gettong latest version", err)
24-
25-
if latestVersion != "" {
26-
latestVersion = ":" + latestVersion
27-
}
28-
2927
cmd := &cobra.Command{
3028
Use: "init",
3129
Short: "Run Testkube Docker Agent and connect to Testkube Pro environment",
@@ -34,6 +32,12 @@ func NewInitCmd() *cobra.Command {
3432
ui.Info("WELCOME TO")
3533
ui.Logo()
3634

35+
if strings.Contains(dockerImage, StableReleasePlaceholder) {
36+
latestVersion, err := common.GetLatestVersion()
37+
ui.ExitOnError("Getting latest version", err)
38+
dockerImage = strings.ReplaceAll(dockerImage, StableReleasePlaceholder, latestVersion)
39+
}
40+
3741
cfg, err := config.Load()
3842
if err != nil {
3943
cliErr := common.NewCLIError(
@@ -135,7 +139,7 @@ func NewInitCmd() *cobra.Command {
135139

136140
cmd.Flags().BoolVarP(&noLogin, "no-login", "", false, "Ignore login prompt, set existing token later by `testkube set context`")
137141
cmd.Flags().StringVar(&dockerContainerName, "docker-container", "testkube-agent", "Docker container name for Testkube Docker Agent")
138-
cmd.Flags().StringVar(&dockerImage, "docker-image", "kubeshop/testkube-agent"+latestVersion, "Docker image for Testkube Docker Agent")
142+
cmd.Flags().StringVar(&dockerImage, "docker-image", "kubeshop/testkube-agent:"+StableReleasePlaceholder, "Docker image for Testkube Docker Agent")
139143

140144
return cmd
141145
}

0 commit comments

Comments
 (0)