Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NOT for search criteria #65

Open
simongray opened this issue Jul 8, 2022 · 2 comments
Open

Implement NOT for search criteria #65

simongray opened this issue Jul 8, 2022 · 2 comments
Labels
enhancement New feature or request nice-to-have

Comments

@simongray
Copy link
Member

The current search functionality is quite powerful, but sometimes you probably want e.g. only letters of third parties mentioning someone without that person themselves being a correspondent in that exchange which is often the case. This requires being able to make search criteria like

[ mentioned: Daniel Jones ]
[ NOT correspondent: Daniel Jones ]

Ways to implement

  1. Double the amount of options in the dropdown adding the negatives, perhaps with a heading. This is probably the easiest way to solve this, however, it might get unruly with that many options.
@simongray simongray added enhancement New feature or request nice-to-have labels Jul 8, 2022
@simongray
Copy link
Member Author

simongray commented Jul 8, 2022

Things that are more difficult to solve:

  • How should the NOT keys be represented in a way that allows for queries to be preserved in the URL?
  • What about the _ (placeholder) symbol?

Perhaps the NOT part is better kept in the value part? e.g.

?document.recipient=!#np56&...

@simongray
Copy link
Member Author

This is proving much more difficult to implement than I had first anticipated. Abandoning for now.

Work-in-progress changes can be found in https://github.com/kuhumcst/glossematics/tree/feature/65-not-criteria.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nice-to-have
Projects
None yet
Development

No branches or pull requests

1 participant