Merge branch 'master' of https://github.com/kumarvna/terraform-azurerm-storage

* 'master' of https://github.com/kumarvna/terraform-azurerm-storage:
  fix: support for allow_blob_public_access attribute has been removed in azurem 3.1.0
  feat: add storage_account_primary_blob_endpoint output
  Add proper variable types

Author: kumarvna

README.md

@@ -277,6 +277,7 @@ Name | Description
 `storage_account_id`|The ID of the storage account
 `sorage_account_name`|The name of the storage account
 `storage_account_primary_location`|The primary location of the storage account
+`storage_account_primary_blob_endpoint`|The endpoint URL for blob storage in the primary location
 `storage_account_primary_web_endpoint`|The endpoint URL for web storage in the primary location
 `storage_account_primary_web_host`|The hostname with port if applicable for web storage in the primary location
 `storage_primary_connection_string`|The primary connection string for the storage account

examples/complete/output.tf

@@ -28,6 +28,11 @@ output "storage_account_primary_location" {
   value       = module.storage.storage_account_primary_location
 }
 
+output "storage_account_primary_blob_endpoint" {
+  description = "The endpoint URL for blob storage in the primary location."
+  value       = module.storage.storage_account_primary_blob_endpoint
+}
+
 output "storage_account_primary_web_endpoint" {
   description = "The endpoint URL for web storage in the primary location."
   value       = module.storage.storage_account_primary_web_endpoint

main.tf

@@ -41,7 +41,6 @@ resource "azurerm_storage_account" "storeacc" {
   account_replication_type  = local.account_replication_type
   enable_https_traffic_only = true
   min_tls_version           = var.min_tls_version
-  allow_blob_public_access  = var.enable_advanced_threat_protection == true ? true : false
   tags                      = merge({ "ResourceName" = substr(format("sta%s%s", lower(replace(var.storage_account_name, "/[[:^alnum:]]/", "")), random_string.unique.result), 0, 24) }, var.tags, )
 
   identity {
@@ -56,9 +55,9 @@ resource "azurerm_storage_account" "storeacc" {
     container_delete_retention_policy {
       days = var.container_soft_delete_retention_days
     }
-    versioning_enabled = var.enable_versioning
+    versioning_enabled       = var.enable_versioning
     last_access_time_enabled = var.last_access_time_enabled
-    change_feed_enabled = var.change_feed_enabled
+    change_feed_enabled      = var.change_feed_enabled
   }
 
   dynamic "network_rules" {

output.tf

@@ -28,6 +28,11 @@ output "storage_account_primary_location" {
   value       = azurerm_storage_account.storeacc.primary_location
 }
 
+output "storage_account_primary_blob_endpoint" {
+  description = "The endpoint URL for blob storage in the primary location."
+  value       = azurerm_storage_account.storeacc.primary_blob_endpoint
+}
+
 output "storage_account_primary_web_endpoint" {
   description = "The endpoint URL for web storage in the primary location."
   value       = azurerm_storage_account.storeacc.primary_web_endpoint

variables.tf

@@ -1,71 +1,85 @@
 variable "create_resource_group" {
   description = "Whether to create resource group and use it for all networking resources"
   default     = false
+  type        = bool
 }
 
 variable "resource_group_name" {
   description = "A container that holds related resources for an Azure solution"
   default     = "rg-demo-westeurope-01"
+  type        = string
 }
 
 variable "location" {
   description = "The location/region to keep all your network resources. To get the list of all locations with table format from azure cli, run 'az account list-locations -o table'"
   default     = "westeurope"
+  type        = string
 }
 
 variable "storage_account_name" {
   description = "The name of the azure storage account"
   default     = ""
+  type        = string
 }
 
 variable "account_kind" {
   description = "The type of storage account. Valid options are BlobStorage, BlockBlobStorage, FileStorage, Storage and StorageV2."
   default     = "StorageV2"
+  type        = string
 }
 
 variable "skuname" {
   description = "The SKUs supported by Microsoft Azure Storage. Valid options are Premium_LRS, Premium_ZRS, Standard_GRS, Standard_GZRS, Standard_LRS, Standard_RAGRS, Standard_RAGZRS, Standard_ZRS"
   default     = "Standard_RAGRS"
+  type        = string
 }
 
 variable "access_tier" {
   description = "Defines the access tier for BlobStorage and StorageV2 accounts. Valid options are Hot and Cool."
   default     = "Hot"
+  type        = string
 }
 
 variable "min_tls_version" {
   description = "The minimum supported TLS version for the storage account"
   default     = "TLS1_2"
+  type        = string
 }
 
 variable "blob_soft_delete_retention_days" {
   description = "Specifies the number of days that the blob should be retained, between `1` and `365` days. Defaults to `7`"
   default     = 7
+  type        = number
 }
 
 variable "container_soft_delete_retention_days" {
   description = "Specifies the number of days that the blob should be retained, between `1` and `365` days. Defaults to `7`"
   default     = 7
+  type        = number
 }
 
 variable "enable_versioning" {
   description = "Is versioning enabled? Default to `false`"
   default     = false
+  type        = bool
 }
 
 variable "last_access_time_enabled" {
   description = "Is the last access time based tracking enabled? Default to `false`"
   default     = false
+  type        = bool
 }
 
 variable "change_feed_enabled" {
   description = "Is the blob service properties for change feed events enabled?"
   default     = false
+  type        = bool
 }
 
 variable "enable_advanced_threat_protection" {
   description = "Boolean flag which controls if advanced threat protection is enabled."
   default     = false
+  type        = bool
 }
 
 variable "network_rules" {
@@ -106,6 +120,7 @@ variable "lifecycles" {
 variable "identity_ids" {
   description = "Specifies a list of user managed identity ids to be assigned. This is required when `type` is set to `UserAssigned` or `SystemAssigned, UserAssigned`"
   default     = null
+  type        = list(string)
 }
 
 variable "tags" {