Include Prepared phase tasks in periodic enqueue to prevent stalling

Tasks in Prepared phase were not included in periodic enqueue (only Accepted phase was included). This meant they only received reconcile calls through watch events, which could cause them to get stuck for long periods when waiting for available slots.

This change adds Prepared phase to the periodic enqueue predicate for both DataUpload and DataDownload controllers, ensuring they get regular reconcile calls (every minute via preparingMonitorFrequency).

This is an alternative proposed solution to the issue described in vmware-tanzu#9447

Signed-off-by: Andrei Kvapil <[email protected]>

Author: kvaps

pkg/controller/data_download_controller.go

@@ -589,6 +589,12 @@ func (r *DataDownloadReconciler) SetupWithManager(mgr ctrl.Manager) error {
 			return true
 		}
 
+		// Include Prepared phase to ensure tasks get regular reconcile calls
+		// This prevents tasks from getting stuck when they're waiting for slots
+		if dd.Status.Phase == velerov2alpha1api.DataDownloadPhasePrepared {
+			return true
+		}
+
 		if dd.Spec.Cancel && !isDataDownloadInFinalState(dd) {
 			return true
 		}

pkg/controller/data_upload_controller.go

@@ -632,6 +632,12 @@ func (r *DataUploadReconciler) SetupWithManager(mgr ctrl.Manager) error {
 			return true
 		}
 
+		// Include Prepared phase to ensure tasks get regular reconcile calls
+		// This prevents tasks from getting stuck when they're waiting for slots
+		if du.Status.Phase == velerov2alpha1api.DataUploadPhasePrepared {
+			return true
+		}
+
 		if du.Spec.Cancel && !isDataUploadInFinalState(du) {
 			return true
 		}