Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable users to customize BTP Operator secret and configMap #901

Open
3 of 9 tasks
PK85 opened this issue Nov 19, 2024 · 1 comment
Open
3 of 9 tasks

Enable users to customize BTP Operator secret and configMap #901

PK85 opened this issue Nov 19, 2024 · 1 comment
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Comments

@PK85
Copy link
Contributor

PK85 commented Nov 19, 2024

Description

We will allow to modify and keep user modifications in the btp-manager-secret.

Reason

Users wants to migrate btp-operator resources and configurations from one k8s cluster into new Kyma cluster.

AC:

  • 1) support label on our btp manager secret sap-btp-manager to skip reconciliation. If secret deleted then reconciliation is back.
    • 1.1) In the BTP manager plutono add dashboard about number of skipped, and be able to see a list of ShootName from those skipped ones
  • 2) if sap-btp-manager secret is changed, immediately reconcile btp-operator
    • 2.1) CM modification is not visible to the btp-operator-controller pod. Only restart of the pod will load it again
    • 2.2) Secret sap-btp-operator-clusterid is always created and INITIAL_CLUSTER_ID from it is always in use. When pod will restart from 2.1 then btp-operator-controller will fail to start because CLUSTER_ID from CM != INITIAL_CLUSTER_ID from secret. panic: ClusterID changed, which is not supported. Please redeploy with --set cluster.id=test_cluster_id goroutine 1 [running]: main.main() /workspace/main.go:140 +0x1d65
    • 2.3) TODO in the BTP-Manager: if user changes CLUSTER_ID in the btp-manager-secret then BTP-Manager deletes a secret sap-btp-operator-clusterid, checks if CM: sap-btp-operator-config has new CLUSTER_ID set, restart sap-btp-operator-controller-manager-58fbb647ff-72ckx pods, checks if sap-btp-operator-clusterid is back with new INITIAL_CLUSTER_ID.
  • 3) E2E integration test
    Issue: End-to-end (e2e) integration test for customizing BTP Manager input secret #921
    PR: E2E BTP Manager secret customization test  #935
  • 4) docs
  • 5) RNs

Agreed label name:

  • kyma-project.io/skip-reconciliation: 'true'

NOTE!:

@szwedm
Copy link
Contributor

szwedm commented Dec 20, 2024

AC:
...

PR with the e2e test: #935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

No branches or pull requests

5 participants