Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple controller-runtime from the Runtime Watcher #130

Open
3 tasks
ruanxin opened this issue Aug 25, 2023 · 3 comments
Open
3 tasks

Decouple controller-runtime from the Runtime Watcher #130

ruanxin opened this issue Aug 25, 2023 · 3 comments
Assignees
Labels
area/quality Related to all activites around quality kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ruanxin
Copy link
Contributor

ruanxin commented Aug 25, 2023

/Description

Runtime Watcher introduced a controller-runtime as a dependency, which can be avoided. It is not needed in the Runtime Watcher as it's way too "heavy" for the use case.

Reasons

We want to reduce maintenance efforts to keep the compatibility between the KLM and Runtime Watcher with controller-runtime in mind.

Acceptance Criteria

  • Remove all controller-runtime dependencies in Runtime Watcher and listener pkg
  • Replace the functionality of controller-runtime by introducing the custom code
  • Verify functionality on landscapes
@janmedrek janmedrek added kind/feature Categorizes issue or PR as related to a new feature. area/quality Related to all activites around quality labels Sep 21, 2023
@janmedrek janmedrek changed the title Decouple controller-runtime from runtime-watcher Decouple controller-runtime from the Runtime Watcher Sep 21, 2023
@jeremyharisch jeremyharisch assigned medmes and unassigned medmes Oct 6, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Dec 5, 2023

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 5, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

@kyma-bot
Copy link
Contributor

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@janmedrek janmedrek removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2023
@janmedrek janmedrek reopened this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Related to all activites around quality kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants