Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogPipeline Beta API #1395

Open
a-thaler opened this issue Aug 27, 2024 · 1 comment
Open

LogPipeline Beta API #1395

a-thaler opened this issue Aug 27, 2024 · 1 comment
Labels
area/logs LogPipeline kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@a-thaler
Copy link
Collaborator

a-thaler commented Aug 27, 2024

Description

With #767 the LogPipeline will be promoted to a beta API. For that, the API of the input section needs to get aligned with the Trace/MetricPipeline APIs. The filter and output sections will stay as they are as they will be faded out together with the fluentbit fade out.

Old API:

input:
  application:
    dropLabels: false
    keepAnnotations: false
    keepOriginalBody: true
    containers: # mutually exclusive
      exclude:
        - ns1
        - ns2
      include:
        - ns3
        - ns4
    namespaces: # mutually exclusive
      system: true
      exclude:
        - ns1
        - ns2
      include:
        - ns3
        - ns4

New API propsal:

input:
  runtime:
    enabled: true # if false, no configuration gets generated. With OTLP, a false value will run the gateway only
    dropLabels: false # stays as is. With OTLP, a new replacement "podLabels" will be added, specifying a list of pod labels to add
    keepAnnotations: false # stays as is. With OTLP, a new replacement "podAnnotations" will be added, specifying a list of pod annotations to add
    keepOriginalBody: true # stays as is
    containers: # stays as is
      exclude:
        - ns1
        - ns2
      include:
        - ns3
        - ns4
    namespaceSelector: #either expression or label. By default an expression gets generated excluding kyma namespaces
        matchExpressions:
        - key: namespace
          operator: In
          values: ["frontend", "backend"]
       matchLabels:
          role: backend

Criterias

  • The LogPipeline beta API will leverage the new input API
  • The beta API stays compatible to alpha via the conversion webhook

Reasons

Attachments

Release Notes


@a-thaler a-thaler added kind/feature Categorizes issue or PR as related to a new feature. area/logs LogPipeline labels Aug 27, 2024
@a-thaler a-thaler mentioned this issue Aug 27, 2024
20 tasks
Copy link

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

1 participant