Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to set environment variables to deployments #377

Closed
tengremlin opened this issue Dec 4, 2023 · 11 comments
Closed

Add capability to set environment variables to deployments #377

tengremlin opened this issue Dec 4, 2023 · 11 comments

Comments

@tengremlin
Copy link

Hello 👋
I wanted to deploy reporter to my cluster, but I've noticed that chart doesn't support setting your own environment variables to workloads. I need this feature so I can set HTTPS_PROXY and NO_PROXY vars. Would you please consider adding this option to your chart?
Thanks
DG

@fjogeleit
Copy link
Member

hi, I'll have a look on it

@kbcbals
Copy link
Contributor

kbcbals commented Dec 5, 2023

@fjogeleit
created the PullRequest for the issue-377. Would you be able to review it please ?

@fjogeleit
Copy link
Member

Released with v2.21.4

@pachr
Copy link

pachr commented Nov 12, 2024

Hello, Have you find a way to use HTTP_PROXY / HTTPS_PROXY / NO_PROXY as environment variables?

I've set up these environments variables in my container with envVars: [], but the container doesn't seem to take these variables into account. I still have a timeout when I try to reach out to the slack webhook api (My proxy has hooks.slack.com in the whitelist, other containers can reach this API)

@fjogeleit
Copy link
Member

which version do you use? Maybe the config is not correctly implemented in the new helm chart

@pachr
Copy link

pachr commented Nov 12, 2024

I'm using the helm chart version 3.0.0-rc.8, which one should I use?

@fjogeleit
Copy link
Member

thats fine, I will take a look on the config

@fjogeleit
Copy link
Member

I found something in the code I need to add to support your configuration. Will create a new version today you can test

@pachr
Copy link

pachr commented Nov 13, 2024

Thanks a lot @fjogeleit I'll be testing that as soon as the new version is available, and I'll let you know

@fjogeleit
Copy link
Member

YOu chould be able to update to the latest RC release with the fixed image

@pachr
Copy link

pachr commented Nov 13, 2024

Perfect it works, awesome, thank you very much 👍 (with the helm chart version 3.0.0-rc.9)

1.7315104989908216e+09 info Slack: PUSH OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants