-
Notifications
You must be signed in to change notification settings - Fork 40
Open
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Some files do not respect the current linter configuration (eslint).
lemverse/core/client/scenes/scene-editor.js
Lines 114 to 119 in 19a80c8
Zones.update(zoneId, { $set: { | |
x1: startPosition.x | 0, | |
y1: startPosition.y | 0, | |
x2: endPosition.x | 0, | |
y2: endPosition.y | 0, | |
} }); |
The expected behavior would be:
Zones.update(zoneId, {
$set: {
x1: startPosition.x | 0,
y1: startPosition.y | 0,
x2: endPosition.x | 0,
y2: endPosition.y | 0,
}
});
I'm thinking about making a PR with all the fixes, but that might create a lot of merge conflicts in the pending pull requests.
Would you allow us to lint correctly the files we're editing in our pull request, or would you rather do one single pull request/commit to fix all the project?
Adding a GitHub action to check the linting of the code would also probably be a good idea.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers