Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] Positive Tabindexes #402

Open
isralduke opened this issue Apr 3, 2023 · 0 comments
Open

[v2] Positive Tabindexes #402

isralduke opened this issue Apr 3, 2023 · 0 comments
Assignees
@isralduke
Labels
v1 v2

Comments

@isralduke
Copy link
Contributor

isralduke commented Apr 3, 2023 •
edited
Loading

Two items Topbar include have positive tabindex values. This is considered bad practice for accessibility. They exist because they were a part of the third-party code used in the early versions of Pelican. The markup should be refactored so that the tabindex values aren’t necessary.

File: _includes/markup/app-screen.njk
Line: 55, 60

File: _includes/header.njk
Line: 3, 9

File: _includes/sidebar.njk
Line: 4

File: _includes/markup/sidebar.njk
Line: 11, 57, 62

File: _includes/markup/skip-link.njk
Line: 1

File: components/app-screen.md
Line: 71, 76
@isralduke isralduke self-assigned this Apr 3, 2023
@isralduke isralduke changed the title Positive Tabindex Values [v2] Positive Tabindexes May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isralduke isralduke

Labels
v1 v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@isralduke